Skip to content

Update transient dependancies for camera to fix build warnings #2493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 7 commits into from
Feb 4, 2025
Merged

Update transient dependancies for camera to fix build warnings #2493

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b04cf2
Update transient dependancies for camera to fix build warnings
ne0rrmatrix Feb 4, 2025
22fd9bf
Merge branch 'main' into TransientDepedanciesUpdates
ne0rrmatrix Feb 4, 2025
52fdb0b
Add Unit Tests
TheCodeTraveler Feb 4, 2025
1459837
Revert "Add Unit Tests"
TheCodeTraveler Feb 4, 2025
676ae1d
Merge branch 'main' into TransientDepedanciesUpdates
TheCodeTraveler Feb 4, 2025
1fbd10a
Add comments
TheCodeTraveler Feb 4, 2025
a3bf666
Merge branch 'TransientDepedanciesUpdates' of https://github.com/ne0r…
TheCodeTraveler Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/CommunityToolkit.Maui.Camera/CommunityToolkit.Maui.Camera.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,19 @@
</ItemGroup>

<ItemGroup Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">
<!-- Required NuGet Packages -->
<PackageReference Include="Xamarin.AndroidX.Camera.Camera2" Version="1.4.1" />
<PackageReference Include="Xamarin.AndroidX.Camera.View" Version="1.4.1" />

<!-- Increase Minimum Version of Transient Dependencies For Xamarin.AndroidX.Camera.Camera2 and Xamarin.AndroidX.Camera.View -->
Copy link
Collaborator

@VladislavAntonyuk VladislavAntonyuk Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need them. we can update the required packages to 1.4.1.1

Copy link
Member Author

@ne0rrmatrix ne0rrmatrix Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating the required packages will just mean upating the transient dependancies. It is an ongoing issue. I have a discussion open about this and I have marked it as a topic for thursday meeting. We need to keep camera and media elment up to date because of issues. ATM not all the depeendacies are lining up in the new packages from last year.

<PackageReference Include="Xamarin.AndroidX.Fragment.Ktx" Version="1.8.5.1" />
<PackageReference Include="Xamarin.AndroidX.Activity.Ktx" Version="1.9.3.1" />
<PackageReference Include="Xamarin.AndroidX.Collection.Jvm" Version="1.4.5.1" />
<PackageReference Include="Xamarin.AndroidX.Collection.Ktx" Version="1.4.5.1" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.LiveData" Version="2.8.7.1" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Runtime" Version="2.8.7.1" />
<PackageReference Include="Xamarin.AndroidX.Lifecycle.Process" Version="2.8.7.1" />

<!-- Ensure Linker does not remove required libraries -->
<None Include="linker.xml" Pack="true" PackagePath="build\$(PackageId).LinkerConfigurationFile.xml" />
</ItemGroup>
Expand Down
Loading