-
Notifications
You must be signed in to change notification settings - Fork 439
Refactor CameraView.CaptureImage
, CameraView.StartCameraPreview
and CameraView.StopCameraPreview
#2655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheCodeTraveler
merged 21 commits into
main
from
Refactor-CameraView.CaptureImage,-StartCameraPreview-and-StopCameraPreview
Jun 5, 2025
Merged
Refactor CameraView.CaptureImage
, CameraView.StartCameraPreview
and CameraView.StopCameraPreview
#2655
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
853cc36
Remove `CommunityToolkit.Maui.Core.Primitives` namespace
TheCodeTraveler 2e799b9
Properly await Tasks
TheCodeTraveler 0278fd3
Remove unused namespaces
TheCodeTraveler a6151b6
Remove `IAsynchronousHandler`
TheCodeTraveler c66df13
Update CameraViewHandler.shared.cs
TheCodeTraveler ddf4994
Update CameraViewHandler.shared.cs
TheCodeTraveler 3547111
Remove unnecessary null checks
TheCodeTraveler 2df36fb
Fix Sample App Compiler Error
TheCodeTraveler 7ff9c41
Update src/CommunityToolkit.Maui.Camera/Views/CameraView.shared.cs
TheCodeTraveler d3b3935
Refactor StopCameraPreview
TheCodeTraveler 348d6c9
Merge branch 'Refactor-CameraView.CaptureImage,-StartCameraPreview-an…
TheCodeTraveler 6d881ec
Refactor `ICameraView`
TheCodeTraveler 40dd627
Update Unit Tests
TheCodeTraveler e094680
Remove invalid XML comment
TheCodeTraveler 1689f14
Update CameraManager.tizen.cs
TheCodeTraveler 40437f4
`dotnet format`
TheCodeTraveler ed3cd56
Revert `StopCameraPreview.StopCameraPreview`
TheCodeTraveler b65f784
Update CameraViewDefaults.shared.cs
TheCodeTraveler 8996040
Merge branch 'main' into Refactor-CameraView.CaptureImage,-StartCamer…
TheCodeTraveler 63ed8c2
Merge branch 'main' into Refactor-CameraView.CaptureImage,-StartCamer…
TheCodeTraveler 27d4835
Merge branch 'main' into Refactor-CameraView.CaptureImage,-StartCamer…
ne0rrmatrix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
samples/CommunityToolkit.Maui.Sample/Pages/Views/CameraView/CameraViewPage.xaml.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
using System.Text; | ||
using CommunityToolkit.Maui.Core.Primitives; | ||
|
||
#if IOS || MACCATALYST | ||
using AVFoundation; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
using CommunityToolkit.Maui.Core.Primitives; | ||
|
||
namespace CommunityToolkit.Maui.Core; | ||
|
||
partial class CameraManager | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,3 @@ | ||
using CommunityToolkit.Maui.Core.Primitives; | ||
|
||
namespace CommunityToolkit.Maui.Core; | ||
|
||
partial class CameraManager | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
src/CommunityToolkit.Maui.Camera/Extensions/CameraViewExtensions.macios.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 0 additions & 12 deletions
12
src/CommunityToolkit.Maui.Camera/Interfaces/IAsynchronouseHandler.cs
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/CommunityToolkit.Maui.Camera/Primitives/CameraFlashMode.shared.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/CommunityToolkit.Maui.Camera/Primitives/CameraPosition.shared.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/CommunityToolkit.Maui.Camera/Primitives/MediaCaptureFailedEventArgs.shared.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/CommunityToolkit.Maui.Camera/Primitives/MediaCapturedEventArgs.shared.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
src/CommunityToolkit.Maui.Camera/Providers/CameraProvider.macios.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/CommunityToolkit.Maui.Camera/Providers/CameraProvider.windows.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.