Skip to content

Fix memory leak by changing now playing artwork request handler #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheCodeTraveler merged 3 commits into from
Jan 20, 2026
Merged

Fix memory leak by changing now playing artwork request handler #3051

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ab6eea
Change now playing artwork request handler
MarcelStommel Jan 20, 2026
a813e76
Fix indentation based on review
MarcelStommel Jan 20, 2026
6db1b75
Extract url into a captured variable instead of using a class
MarcelStommel Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions src/CommunityToolkit.Maui.MediaElement/Primitives/Metadata.macios.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using AVFoundation;
using CoreGraphics;
using CoreMedia;
using Foundation;
using MediaPlayer;
Expand Down Expand Up @@ -76,32 +77,37 @@ public void SetMetadata(AVPlayerItem? playerItem, IMediaElement? mediaElement)
Metadata.ClearNowPlaying();
return;
}

var proxy = new RequestHandlerProxy(mediaElement.MetadataArtworkUrl);

NowPlayingInfo.Title = mediaElement.MetadataTitle;
NowPlayingInfo.Artist = mediaElement.MetadataArtist;
NowPlayingInfo.PlaybackDuration = playerItem?.Duration.Seconds ?? 0;
NowPlayingInfo.IsLiveStream = false;
NowPlayingInfo.PlaybackRate = mediaElement.Speed;
NowPlayingInfo.ElapsedPlaybackTime = playerItem?.CurrentTime.Seconds ?? 0;
NowPlayingInfo.Artwork = new(boundsSize: new(320, 240), requestHandler: _ => GetImage(mediaElement.MetadataArtworkUrl));
NowPlayingInfo.Artwork = new(new(320, 240), proxy.RequestHandler);
MPNowPlayingInfoCenter.DefaultCenter.NowPlaying = NowPlayingInfo;
}

static UIImage GetImage(string imageUri)
{
try
{
if (imageUri.StartsWith(Uri.UriSchemeHttp, StringComparison.OrdinalIgnoreCase))
{
return UIImage.LoadFromData(NSData.FromUrl(new NSUrl(imageUri))) ?? defaultUIImage;
}
return defaultUIImage;
}
catch
{
return defaultUIImage;
}
}
sealed class RequestHandlerProxy(string metadataArtworkUrl)
{
public UIImage RequestHandler(CGSize size)
{
try
{
if (metadataArtworkUrl.StartsWith(Uri.UriSchemeHttp, StringComparison.OrdinalIgnoreCase))
{
return UIImage.LoadFromData(NSData.FromUrl(new NSUrl(metadataArtworkUrl))) ?? defaultUIImage;
}
return defaultUIImage;
}
catch
{
return defaultUIImage;
}
}
}

MPRemoteCommandHandlerStatus SeekCommand(MPRemoteCommandEvent? commandEvent)
{
Expand Down
Loading