-
Notifications
You must be signed in to change notification settings - Fork 493
Add BindablePropertyDefaultValueCreatorAnalyzer to to avoid Static References from being passed into CreateDefaultValueMethodName when using [BindableProperty] and [AttachedBindableProperty<T>].
#3096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheCodeTraveler
wants to merge
17
commits into
main
Choose a base branch
from
Remove-All-Static-References-From-CreateDefaultValue
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
078f380
Add Analyzers
TheCodeTraveler fc60f23
Update BindablePropertyDefaultValueCreatorAnalyzerTests.cs
TheCodeTraveler ec4ca74
Update NavigationBar.shared.cs
TheCodeTraveler 9401677
Update Resx
TheCodeTraveler 82cc485
Update src/CommunityToolkit.Maui.Analyzers/BindablePropertyDefaultVal…
TheCodeTraveler b5b5519
Update `AnalyzerReleases.Shipped.md`
TheCodeTraveler 4b6e20c
Add Benchmarks
TheCodeTraveler 0d7cfa7
Update BindablePropertyDefaultValueCreatorAnalyzerBenchmarks.cs
TheCodeTraveler 39ba194
Merge branch 'main' into Remove-All-Static-References-From-CreateDefa…
TheCodeTraveler f815aa7
Add Tests
TheCodeTraveler bc6b5b6
Add Support For Delegate
TheCodeTraveler e44298a
Add support for `const`
TheCodeTraveler 2bc53e7
Update BindablePropertyDefaultValueCreatorAnalyzerTests.cs
TheCodeTraveler 08439b2
Update src/CommunityToolkit.Maui.Analyzers/Resources.Designer.cs
TheCodeTraveler 2f1962d
Update src/CommunityToolkit.Maui.Analyzers/AnalyzerReleases.Shipped.md
TheCodeTraveler 7628828
Update Directory.Build.props
TheCodeTraveler 4743979
Merge branch 'main' into Remove-All-Static-References-From-CreateDefa…
TheCodeTraveler File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
...oolkit.Maui.Analyzers.Benchmarks/BindablePropertyDefaultValueCreatorAnalyzerBenchmarks.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| using BenchmarkDotNet.Attributes; | ||
| using CommunityToolkit.Maui.Analyzers.UnitTests; | ||
| namespace CommunityToolkit.Maui.Analyzers.Benchmarks; | ||
|
|
||
| [MemoryDiagnoser] | ||
| public class BindablePropertyDefaultValueCreatorAnalyzerBenchmarks | ||
| { | ||
| static readonly BindablePropertyDefaultValueCreatorAnalyzerTests bindablePropertyDefaultValueCreatorAnalyzerTests = new(); | ||
| static readonly AttachedBindablePropertyDefaultValueCreatorAnalyzerTests attachedBindablePropertyDefaultValueCreatorAnalyzerTests = new(); | ||
|
|
||
| [Benchmark] | ||
| public Task BindablePropertyDefaultValueCreatorAnalyzerTests_VerifyErrorWhenDefaultValueCreatorMethodHasBlockBodyReturningStaticReadonlyField() | ||
| { | ||
| return bindablePropertyDefaultValueCreatorAnalyzerTests.VerifyErrorWhenDefaultValueCreatorMethodHasBlockBodyReturningStaticReadonlyField(); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public Task AttachedBindablePropertyDefaultValueCreatorAnalyzerTests_VerifyErrorWhenDefaultValueCreatorMethodHasBlockBodyReturningStaticReadonlyField() | ||
| { | ||
| return attachedBindablePropertyDefaultValueCreatorAnalyzerTests.VerifyErrorWhenDefaultValueCreatorMethodHasBlockBodyReturningStaticReadonlyField(); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public Task BindablePropertyDefaultValueCreatorAnalyzerTests_VerifyErrorWhenDefaultValueCreatorMethodReturnsStaticReadonlyPropertyFromDifferentClass() | ||
| { | ||
| return bindablePropertyDefaultValueCreatorAnalyzerTests.VerifyErrorWhenDefaultValueCreatorMethodReturnsStaticReadonlyPropertyFromDifferentClass(); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public Task AttachedBindablePropertyDefaultValueCreatorAnalyzerTests_VerifyErrorWhenDefaultValueCreatorMethodReturnsStaticReadonlyPropertyFromDifferentClass() | ||
| { | ||
| return attachedBindablePropertyDefaultValueCreatorAnalyzerTests.VerifyErrorWhenDefaultValueCreatorMethodReturnsStaticReadonlyPropertyFromDifferentClass(); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public Task BindablePropertyDefaultValueCreatorAnalyzerTests_VerifyNoErrorWhenDefaultValueCreatorMethodHasBlockBodyReturningNewInstance() | ||
| { | ||
| return bindablePropertyDefaultValueCreatorAnalyzerTests.VerifyNoErrorWhenDefaultValueCreatorMethodHasBlockBodyReturningNewInstance(); | ||
| } | ||
|
|
||
| [Benchmark] | ||
| public Task AttachedBindablePropertyDefaultValueCreatorAnalyzerTests_VerifyNoErrorWhenDefaultValueCreatorMethodHasBlockBodyReturningNewInstance() | ||
| { | ||
| return attachedBindablePropertyDefaultValueCreatorAnalyzerTests.VerifyNoErrorWhenDefaultValueCreatorMethodHasBlockBodyReturningNewInstance(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.