Improve semicolon delimiter consistency, fix IsNetstandard property#244
Merged
Arlodotexe merged 1 commit intomainfrom Jan 2, 2025
Merged
Improve semicolon delimiter consistency, fix IsNetstandard property#244Arlodotexe merged 1 commit intomainfrom
IsNetstandard property#244Arlodotexe merged 1 commit intomainfrom
Conversation
Arlodotexe
added a commit
to CommunityToolkit/Labs-Windows
that referenced
this pull request
Jan 2, 2025
Sergio0694
approved these changes
Jan 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes minor changes to the target framework properties and the
UseTargetFrameworksscript to ensure consistency by adding semicolons at the end of framework lists.Changes to target framework properties:
MultiTarget/AvailableTargetFrameworks.props: Added a semicolon at the end of theDotnetStandardCommonTargetFrameworkproperty value.MultiTarget/EnabledMultiTargets.props: Added a semicolon at the end of theEnabledMultiTargetsproperty value.Changes to
UseTargetFrameworksscript:MultiTarget/UseTargetFrameworks.ps1: Modified the regex replacement to include a semicolon at the end of theEnabledMultiTargetsproperty value.The delimiter is needed to avoid problems with the
Containschecks between TFMs such asnet9.0andnet9.0-windows*.