Skip building components that don't target the requested WinUI version#254
Merged
Arlodotexe merged 1 commit intomainfrom Jan 29, 2025
Merged
Skip building components that don't target the requested WinUI version#254Arlodotexe merged 1 commit intomainfrom
Arlodotexe merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #252
Our build script will now skip building components that don't target the specific WinUI version requested.
Notably, while this doesn't cause issues for any components we have now, if we have any components in the future which target no version of WinUI this will prevent them from compiling, while before it picked WinUI 2 or 3 at random from the CI matrix. We'll need #251 to fix this properly.