Port SystemInformation and associated helpers#600
Draft
Lamparter wants to merge 4 commits intoCommunityToolkit:mainfrom
Draft
Port SystemInformation and associated helpers#600Lamparter wants to merge 4 commits intoCommunityToolkit:mainfrom
SystemInformation and associated helpers#600Lamparter wants to merge 4 commits intoCommunityToolkit:mainfrom
Conversation
Sergio0694
reviewed
Jan 27, 2025
Member
There was a problem hiding this comment.
I'm not sure I see the point of these APIs. Perhaps SystemInformation on its own, but most of the other APIs seem to be just very low value wrappers over system APIs. @Arlodotexe we should consider whether it makes sense to bring back these APIs at all.
Member
I agree, this needed proper evaluation as per #602. |
1 task
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As referenced in #17
PR Type: Added new helpers (from WCT 7.x)
PR Checklist
Please check if your PR fulfills the following requirements:
SystemInformationand associated helpersStorageFileHelper,ApplicationDataStorageHelperand theOSVersionstruct have not yet been ported. I have ported these in this PR, with support for multiple platforms (and Uno support(-ish)).