Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook up TokenizingTextBox AutoSuggestBoxStyle #657

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hook up TokenizingTextBox AutoSuggestBoxStyle #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/TokenizingTextBox/src/TokenizingTextBox.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

<Style x:Key="DefaultTokenizingTextBoxStyle"
TargetType="controls:TokenizingTextBox">
<Setter Property="AutoSuggestBoxStyle" Value="{StaticResource SystemAutoSuggestBoxStyle}" />
<Setter Property="AutoSuggestBoxTextBoxStyle" Value="{StaticResource TokenizingTextBoxTextBoxStyle}" />
<Setter Property="Foreground" Value="{ThemeResource TextControlForeground}" />
<Setter Property="Background" Value="{ThemeResource TextControlBackground}" />
Expand Down
2 changes: 1 addition & 1 deletion components/TokenizingTextBox/src/TokenizingTextBoxItem.AutoSuggestBox.xaml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main comment is that the SystemAutoSuggestBoxStyle is defined here in this file compared to where it's now getting referenced in TokenizingTextBox.xaml. So, it'd probably have to move to be properly looked up?

However, I'm not even sure if this is needed anymore and if it's a remnant of system WUX xaml when we weren't building on top of WinUI 2, like we are now for UWP and WinUI 3 for WASDK. Like we may just be able to reference DefaultAutoSuggestBoxStyle now?

@miksalmon did you notice a difference before/after here?

FYI @niels9001 who may be able to comment here. Doing a diff between what we have and the system style it doesn't appear there's a ton of big differences. Mostly the alignment top vs. stretch.

Copy link
Author

@miksalmon miksalmon Mar 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-hawker During testing, I confirmed it works by keeping it there. I tested by modifying SystemAutoSuggestBoxStyle and making sure this was getting applied properly, which it did.

It can probably look it up just fine because TokenizingTextBoxItem.AutoSuggestBox.xaml is imported in TokenizingTextBox.xaml where it's used.

I'll be honest, I didn't verify what the actual differences were. It's possible we could use the default style or the default SystemAutoSuggestBoxStyle instead and get rid of this redefined one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra info, @niels9001 any thoughts here?

Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@
ItemTemplate="{Binding Path=Owner.SuggestedItemTemplate, RelativeSource={RelativeSource Mode=TemplatedParent}}"
ItemsSource="{Binding Path=Owner.SuggestedItemsSource, RelativeSource={RelativeSource Mode=TemplatedParent}}"
PlaceholderText="{Binding Path=Owner.PlaceholderText, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Style="{StaticResource SystemAutoSuggestBoxStyle}"
Style="{Binding Path=Owner.AutoSuggestBoxStyle, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Text="{Binding Text, Mode=TwoWay}"
TextBoxStyle="{StaticResource TokenizingTextBoxTextBoxStyle}"
TextMemberPath="{Binding Path=Owner.TextMemberPath, RelativeSource={RelativeSource Mode=TemplatedParent}}"
Expand Down