Skip to content

Conversation

@AndrewKeepCoding
Copy link
Contributor

Fixes #407

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Microsoft.UI.Xaml.Markup.XamlParseException is thrown when TargetObject is bound using Binding.

<behaviors:StartAnimationAction
    Animation="{Binding ElementName=MoveAnimation}"
    TargetObject="{Binding ElementName=TargetImage}" />

What is the new behavior?

The animation is bound to the TargetObject as expected.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • Tested code with current supported SDKs
  • New component
    • Documentation has been added
    • Sample in sample app has been added
    • Analyzers are passing for documentation and samples
    • Icon has been created (if new sample) following the Thumbnail Style Guide and templates
  • Tests for the changes have been added (if applicable)
  • Header has been added to all new source files
  • Contains NO breaking changes

Other information

Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizarre, I thought we had fixed this already. Maybe it was a different instance of a similar copy-paste problem.

Thanks so much! 🦙❤️

@michael-hawker michael-hawker merged commit df8aa8a into CommunityToolkit:main Dec 18, 2025
23 checks passed
@AndrewKeepCoding AndrewKeepCoding deleted the fix-startanimationaction-targetobject-issue branch December 18, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StartAnimationAction's TargetObject DP is incorrectly declared

2 participants