-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CroppedRegionChanged event for ImageCropper. #3179
Closed
HHChaos
wants to merge
6
commits into
CommunityToolkit:master
from
HHChaos:hhchaos/imagecropper-oncropchangedevent
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4975258
Add CroppedRegionChanged event for ImageCropper.
HHChaos a93e398
Merge branch 'master' into hhchaos/imagecropper-oncropchangedevent
HHChaos a3bea61
Update Microsoft.Toolkit.Uwp.UI.Controls/ImageCropper/ImageCropperCro…
HHChaos bc97e99
Update Microsoft.Toolkit.Uwp.UI.Controls/ImageCropper/ImageCropper.cs
HHChaos 530e171
Merge branch 'master' into hhchaos/imagecropper-oncropchangedevent
HHChaos 52ed671
Merge branch 'master' into hhchaos/imagecropper-oncropchangedevent
Kyaa-dost File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
Microsoft.Toolkit.Uwp.UI.Controls/ImageCropper/ImageCropperCroppedRegionChangedEventArgs.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using Windows.Foundation; | ||
|
||
namespace Microsoft.Toolkit.Uwp.UI.Controls | ||
{ | ||
/// <summary> | ||
///为< 请参阅cref = “ ImageCropper.CroppedRegionChanged ” />事件提供事件数据。 | ||
/// </summary> | ||
public sealed class ImageCropperCroppedRegionChangedEventArgs | ||
{ | ||
/// <summary> | ||
/// Gets the region that is currently cropped in the control. | ||
/// </summary> | ||
public Rect NewRegion { get; internal set; } | ||
|
||
/// <summary> | ||
/// Gets the region that was previously cropped in the control. | ||
/// </summary> | ||
public Rect OldRegion { get; internal set; } | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like something happened with GitHub accepting the comment? This is causing the CI to fail as it's not a valid XML doc comment anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that github accepted the changes that were automatically translated by Google Translate (because my chrome automatically translated the webpage into Chinese), maybe it should be a github bug? 🤣
Let me fix it.