-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Animatable tile brush #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Animatable tile brush #3864
Conversation
Update TileControl sample to use instead Deprecate TileControl
Thanks hawkerm for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
|
Clean-up Brush Properties for use in XAML
Hi @hawkerm will you be needing any more assistance on this feature?
@michael-hawker are we just waiting for brave souls to review this PR? |
FYI @XAML-Knight: @hawkerm == @michael-hawker 😉 - This is just my personal account as I was messing around with this for a weekend project and not for anything specific we have priorities on. I had encountered a few odd edge cases when the confines of the target surface were super narrow, so I was debating if that was a show-stopper or not, though probably more things we should file as potential composition issues. I should at least clean-up the PR so it can build in the pipeline for easier testing, but we should move this out of the 7.1 milestone as I don't think there'll be time to finalize it (though I may pillage a tiny bit of this for Shadow Animations if it's needed). |
Fixes #3631
Extends the existing effect animations API to allow creation/manipulation of a
CompositionSurfaceBrush
which lets us manipulate a brush's properties directly outside the visual. This was the key into animating a tiled background.There are some questions and remaining issues to investigate. Not sure if they're issues with the animation APIs or composition. However, the base cases work. I've also validated that between this and
ParallaxView
in the platform, they should serve as replacements to theTileControl
so it can be deprecated.PR Type
What kind of change does this PR introduce?
What is the current behavior?
TileControl mass copies an image across a surface to tile it and animate it.
What is the new behavior?
Use
BorderEffect
from Win2D to do tiling effect in graphics layer, then expose a way with a newSurfaceBrushFactory
to animate aCompositionSurfaceBrush
's properties via the new 7.0 animation layer.PR Checklist
Please check if your PR fulfills the following requirements:
TO DO
RotationAngleInDegrees
@Sergio0694 found another odd case here I can send you to help investigate.