Skip to content

sprite: offset-y can take % now #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

JaredSartin
Copy link

Fixes #1012

@scottdavis
Copy link
Member

can you update the test cases also?

@scottdavis
Copy link
Member

integration tests for the sass extensions are here: https://github.com/chriseppstein/compass/blob/stable/test/integrations/sprites_test.rb

@JaredSartin
Copy link
Author

I have not had time to write tests... I will do my best too soon.

@ken210
Copy link

ken210 commented Oct 29, 2012

Would like to see this commit merged

@scottdavis
Copy link
Member

Awaiting tests before merging

@norsewulf
Copy link

So this is still a work in progress right?

@JaredSartin
Copy link
Author

I have had no time to spare to get the test suite running on my machine. It
breaks. If I can get it working, then I will write tests. If anyone else
knows Ruby, feel free to write the tests and make your own fix.

On Monday, February 4, 2013, norsewulf wrote:

So this is still a work in progress right?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1014#issuecomment-13103806.

@developer-collin
Copy link

Would love to see this merged.

@ghost ghost assigned scottdavis Dec 4, 2013
@chriseppstein
Copy link
Member

This has languished long enough. @scottdavis, can you either accept this patch and add some tests or reject it, please?

@JaredSartin
Copy link
Author

I attempted to run the test suite multiple times and it nearly messed up my
dev environment and still didn't run. Sorry I was not able to provide specs
for this.

On Wednesday, December 4, 2013, Chris Eppstein wrote:

This has languished long enough. @scottdavishttps://github.com/scottdavis,
can you either accept this patch and add some tests or reject it, please?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1014#issuecomment-29855991
.

@chriseppstein
Copy link
Member

I've reopened the feature request. I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch.

@chriseppstein
Copy link
Member

Should be on top of the changes coming in #1771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sprite Offset-y doesn't respond to percentage
6 participants