Rewrote PR #1303 and added a test #1310
Conversation
| if image | ||
| row = Compass::SassExtensions::Sprites::ImageRow.new(width + 2 * image.spacing) | ||
| else | ||
| row = Compass::SassExtensions::Sprites::ImageRow.new(width + 2 * @images[0].spacing) |
There was a problem hiding this comment.
I would DRY this up a bit and calculate the width before calling ImageRow.new within the if statement.
|
Tests are failing. |
|
How do I ignore the sass_master gemfile tests to make the tests pass? |
ghost
assigned 
|
Scott has done a bunch of refactoring for the sprites and has extracted sprites to their own rubygem etc. I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch. |
|
Should be on top of the changes coming in #1771. |
Changed width and height calculations according to @chriseppstein's comments and added a test that specifically tests the total width and height smart layout in a case with spacing.
(And also removed whitespace and pushed on master instead of stable)
This does not fix the "spacing on the edges" issue, but IMO is still better than having the smart layout not consider spacing.