Added support for spacing to smart sprite layouts. #1314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have been having the same issue and I would love to see/help this get merged. |
|
Hi, |
|
👍 |
ghost
assigned 
|
I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch. @scottdavis has extracted sprites to a plugin and we'll be releasing that in 1.1. This needs to be patch on top of his work which should land soon. |
|
Should be on top of the changes coming in #1771. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes no changes to the RowFitter calculations - it merely adds spacing around the sprites after they've already been divided into rows. As a result, this could potentially generate a suboptimal layout given the right combination of images and spacing settings, but I suspect that would be fairly unlikely in most use cases. If it is deemed to be a major issue, the RowFitter algorithm could always be optimised at a later stage.