Skip to content

added always even positions to the smart-layout with an extra padding of 2 #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Conversation

afewyards
Copy link

Added the always even positions to the smart layout to fix the ghosting of retina sprites. they get divided and if there positions is odd the position will be not on a int. This will fix that

@scottdavis
Copy link
Member

I like the thought behind this patch, but it needs the test cases updated before i accept it.

@afewyards
Copy link
Author

ahh, ok will do that when I got more time.. prob somewhere later this week.

@afewyards afewyards closed this Sep 30, 2013
@afewyards afewyards reopened this Sep 30, 2013
@chriseppstein
Copy link
Member

ping?

@afewyards
Copy link
Author

ok, took a while but I updated the test cases and altered the sprite generation a bit to have a better/good result.

@afewyards
Copy link
Author

I see that "rcov" fails in the 1.9+ builds.. as that needs to be converted into "simplecov" that is not part of this pull request.

@afewyards afewyards changed the title added always even positions to the smart-layout with an extra padding of... added always even positions to the smart-layout with an extra padding of 2 Apr 14, 2014
@chriseppstein
Copy link
Member

I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch.

@scottdavis has refactored sprites considerably, we need to rebase this work to take his recent changes (soon to land on master) into account.

@chriseppstein
Copy link
Member

Should be on top of the changes coming in #1771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants