-
Notifications
You must be signed in to change notification settings - Fork 1.2k
added always even positions to the smart-layout with an extra padding of 2 #1392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I like the thought behind this patch, but it needs the test cases updated before i accept it. |
ahh, ok will do that when I got more time.. prob somewhere later this week. |
ping? |
ok, took a while but I updated the test cases and altered the sprite generation a bit to have a better/good result. |
I see that "rcov" fails in the 1.9+ builds.. as that needs to be converted into "simplecov" that is not part of this pull request. |
I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch. @scottdavis has refactored sprites considerably, we need to rebase this work to take his recent changes (soon to land on master) into account. |
Should be on top of the changes coming in #1771. |
Added the always even positions to the smart layout to fix the ghosting of retina sprites. they get divided and if there positions is odd the position will be not on a int. This will fix that