Skip to content

Consider spacing on smart layout. Improves #1303 Fixes #718 #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

camilonova
Copy link

No description provided.

@scottdavis
Copy link
Member

Now we are getting there!

@camilonova
Copy link
Author

@scottdavis great, so how can we make this happen?

@scottdavis
Copy link
Member

You will need to create a unit test for this patch here: https://github.com/chriseppstein/compass/blob/master/test/units/sprites/layout_test.rb#L123

@ghost ghost assigned scottdavis Dec 3, 2013
@camilonova
Copy link
Author

@scottdavis I'll need help for the unit test.

@camilonova
Copy link
Author

@scottdavis can I get a little help in here?

@chriseppstein
Copy link
Member

I'm closing this PR because there's been too much change since it was initially submitted. Sorry, We're going to do better going forward. Hopefully, someone can resubmit the change against 1.0. Features should be submitted to the master branch, bug fixes to the stable branch.

@chriseppstein
Copy link
Member

Should be on top of the changes coming in #1771.

@camilonova
Copy link
Author

So sad.

@chriseppstein
Copy link
Member

@camilonova I agree. I don't think it will be hard to clean this patch up. I'm trying to get this project back on track, and that meant focusing on some core things for a while. But now we're ready to receive PRs like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants