Added support for the $<sprite-map>-prefix attribute. #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix invalid method call for strip_trailing_seperator in configuration
|
This is a good patch, but we need to have it rebased on top of master after #1771 lands. |
scottdavis
force-pushed
the
stable
branch
4 times, most recently
from
34c8530 to
d5df161
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the $-prefix attribute the default prefix (= sprite folder name) for the generated sprite classes can be overwritten.
My use case: In some cases we use our company branded icons as single images, in other cases they are merged in sprite sheets. It's easier for everyone if file names and sprite classes are identical. So i don't want the sprite classes to be prefixed with their including folder's name. In this case I set the $-prefix to null.
(This could also be the use case for Issue #249)
I found the existing $-prefix attribute in the original code unused. So I hijacked it for my purposes.