core(py): add auto_upload_download_files boolean flag to Composio()
#2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jkomyno
changed the title
auto_upload_download_files boolean flag to Composio()
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| # Process file uploadable schemas | ||
| for tool in router_tools: | ||
| tool.input_parameters = ( | ||
| tools_model._file_helper.process_file_uploadable_schema( |
There was a problem hiding this comment.
ToolRouter ignores auto_upload_download_files setting from SDK
Medium Severity
The ToolRouter always calls process_file_uploadable_schema unconditionally, ignoring the auto_upload_download_files setting. When ToolRouter is initialized in sdk.py, the auto_upload_download_files parameter isn't passed to it. Inside _create_tools_fn, a new ToolsModel is created without this parameter, defaulting to True. Meanwhile, tools.py correctly gates this processing with if self._auto_upload_download_files. This causes inconsistent behavior: users setting auto_upload_download_files=False on Composio() will find that composio.tools respects the setting but composio.tool_router does not.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
auto_upload_download_files: boolto Python'sComposio()constructor.