toml11/nlohmann-json: avoid symbol clashes with different versions in upstream dependencies #5367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just ran a test, the segfault that I saw is fixed by this. |
psychocoderHPC
added
bug
|
I was just going to fix this for nlohmann-json, but noticed that it has already been fixed with version 3.11 nlohmann/json#3590. Internally, we still use version 3.9.1. I will remove my workaround and upgrade the single header instead. |
franzpoeschel
force-pushed
the
fix-toml-json-version-mismatches
branch
from
da25de2 to
f0a3675
Compare
franzpoeschel
force-pushed
the
fix-toml-json-version-mismatches
branch
from
f0a3675 to
f711387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5355
This is a relatively simple workaround for the issue documented therein, especially as it does not require changes in openPMD and hence fixes the problem also for old versions.
Explanation:
inline namespacecreates a namespace that does not actually need to be used in including code. Instead, it only instructs the linker to emit qualified symbols, thus avoiding the problematic symbol clashes.Aside from this, I am currently experimenting with automatically installing the internally shipped versions of toml11 / nlohmann-json along with openPMD uponmake installin openPMD/openPMD-api#1757. The far goal would be to use the logic described there as a "protocol" for openPMD and PIConGPU to agree on common versions for internal header-only libraries.TODO: