Fix beat loop wrapping for copied clips#10
Merged
Conversation
linearPositionToLoopPosition mapped a beat position to its loop-relative phase via loopStart + fmod(position, loopLength). That formula only gives the correct phase when loopStart == 0; if the loop region begins at a non-zero source beat (the right side of a split, a time-range copy that began mid-loop, or any clip whose user-set loop start isn't bar 1 of the source) the read position folded outside the loop and the WaveNode rendered silence past the loop boundary. Subtract loopStart before the modulo, and handle negative phase explicitly so positions before the loop start wrap forward rather than landing at a negative offset.
lucaromagnoli
force-pushed
the
fix/beat-loop-wrap-copied-clips
branch
from
e2d0d75 to
dbf2994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Engine-side counterpart to MAGDA's beat-mode clip copy/paste fixes. Adjusts WaveNode and EditNodeBuilder so that a copied autoTempo+looped clip wraps its source-beat phase correctly instead of rendering silence past the loop boundary.
Test plan