LFOModifier: gate output by MIDI activity in note-trigger mode#13
Merged
Conversation
Adds setGateOnTriggerSource(): when set and syncType == note, applyToBuffer drives the existing gated_ flag from the MIDI stream itself — NoteOn ungates and increments a held-note count, NoteOff (vel-0-aware) decrements it, AllNotesOff/AllSoundOff hard-resets. Gate re-asserts once the count returns to zero. This lets MIDI-trigger LFOs behave like envelopes — output sits at 0 between notes — without changing the free-run sync mode for callers that don't opt in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setGateOnTriggerSource(bool)toLFOModifier. When set andsyncType == note,applyToBufferdrives the existinggated_flag from the MIDI stream itself: NoteOn ungates and increments a held-note count, NoteOff (vel-0-aware) decrements it, AllNotesOff / AllSoundOff hard-resets. Gate re-asserts once the count returns to zero.Why
Previously a note-mode LFO only resynced phase on note-on; its output free-ran between MIDI notes, which forced consumers to maintain a parallel "is the LFO running" simulation just to make UI animations and audio agree. With this opt-in flag, the audio engine itself owns the running state.
Behavior
syncType == note: gate follows MIDI activity, output sits at 0 between notes.syncType != note: flag is ignored (still no gate).Test plan