Plugins: Fix incorrect plugin loading from multi-component VST3 bundles#2
Merged
Merged
Conversation
Some VST3 bundles contain multiple plugin components sharing the same .vst3 file (e.g., Serum 2 instrument and Serum 2 FX effect). When loading such plugins, the wrong component could be selected due to fuzzy identifier matching returning the first match regardless of the plugin name. Changes: - Store pluginFormatName in the plugin ValueTree state to preserve the exact format type across save/load cycles - Add name verification after getTypeForIdentifierString() matches to ensure the matched plugin name corresponds to the requested plugin - Add a more specific matching pass in findMatchingPluginDescription() that considers uniqueId + name + fileOrIdentifier together - Add VST3 to the format prefix fallback checks (was missing, only had VST and AudioUnit) This ensures that when a project requests "Serum 2" (instrument), it correctly loads the instrument component rather than "Serum 2 FX" (effect), even when both share the same .vst3 bundle file path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some VST3 bundles contain multiple plugin components sharing the same .vst3 file (e.g., Serum 2 instrument and Serum 2 FX effect). When loading such plugins, the wrong component could be selected due to fuzzy identifier matching returning the first match regardless of the plugin name.
Changes:
This ensures that when a project requests "Serum 2" (instrument), it correctly loads the instrument component rather than "Serum 2 FX" (effect), even when both share the same .vst3 bundle file path.