Skip to content

Conversation

@td202
Copy link
Contributor

@td202 td202 commented Nov 18, 2025

Purpose

_Describe the purpose of the pull request, link to issue describing the problem, etc.

Changes

_Describe the changes that were needed.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

CLA acceptance

_Remove if not applicable.

By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0

drsk0 and others added 11 commits November 3, 2025 15:19
* COR-1980: update SendBlockItemRequest::get_v0_format

This adds the new implementations for
  - BlockItem::AccountTransactionV1
  - BlockItem::RawBlockItem

* update CHANGELOG

* Update concordium-node/src/grpc2.rs

Co-authored-by: Søren Bruus Zeppelin <[email protected]>

* Update concordium-node/src/grpc2.rs

Co-authored-by: Søren Bruus Zeppelin <[email protected]>

* fix compilation

* simplify `TryFrom<AccountTransactionV1Signatures` implementation

* Update concordium-node/src/grpc2.rs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* concordium-base: update submodule

* add stub for missing transaction verifier implementation

* format

* fix Versioned::from(0)

This doesn't compile unfortunately.

---------

Co-authored-by: drsk <[email protected]>
Co-authored-by: Søren Bruus Zeppelin <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
Add transaction verification results for sponsored transactions.
* SPO-9: extend AccountTransactionDetails

This extacts the optional sponsor from the received transaction and
fills the new sponsor field of `AccountTransactionDetails`.

* update CHANGELOG

* concordium-base:submodule update

* set TransactionSummaryVersion ~ TransactionOutcomesVersion

* concordium-base: update submodule

* propagate changes of concordium-base

* update benchmark code

* update getResults

* fix assertApplied

* extend hash tests for TOV3

* fix transactionOutcomesHashV1

* concordium-base: update submodule

* Update concordium-consensus/benchmarks/transactions/SchedulerBench/Helpers.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/GlobalState/BlockState.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/Types/TransactionOutcomes.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/Types/TransactionOutcomes.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/Scheduler.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/GlobalState/BlockState.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* remove changelog entry

* format

* fix tests/benchmark

* drop tsSponsorField logic from scheduler

* Apply suggestion from @td202

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Apply suggestion from @td202

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Apply suggestion from @td202

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Apply suggestion from @td202

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Apply suggestion from @td202

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* small fixes after suggestions

* added DataKinds pragma

* more review comments

* format

* cosmetics

* format

* fix a billion tests

* Update concordium-consensus/src/Concordium/Scheduler/Environment.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/Scheduler.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* remove wtcSponsorDetails field

---------

Co-authored-by: drsk <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
@github-actions
Copy link

The file size of the WebAssembly PLT deployment unit is 277268B.

td202 and others added 13 commits November 18, 2025 15:41
* SPO-10: transaction verifier implementation

* one passing test with valid transaction data

* transaction verifier tests

* fix transaction verifier

the signature verifiaction for sponsored transactions is different from
the signature verifaction of normal transactions.

* clean up

* Update concordium-consensus/src/Concordium/TransactionVerification.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* Update concordium-consensus/src/Concordium/TransactionVerification.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* concordium-base: update submodule

* Update concordium-consensus/src/Concordium/TransactionVerification.hs

Co-authored-by: Thomas Dinsdale-Young <[email protected]>

* update call to verifySponsoredTransaction

* set unused type family instances to Void

* factor out sender/sponsor signatures

* update minimal energy amount in tests

* add EnergyRate to test data

* update minimum nonce

* introduce `checkExactNonce` field in test data

* add test for succeeding tx when checkExactNonce == False

* remove test .dat file

* Add a test for NormalTransactionDuplicateNonce error case

* refactor test data creation

* incremented nonce, so no zero nonce appear in the tests

* cosmetics

* replace dummy type family

* add comment

* format

---------

Co-authored-by: drsk <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
…ctions' into sponsored-transactions-execution-charging
…tion-charging

Sponsored transactions execution charging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants