-
Notifications
You must be signed in to change notification settings - Fork 25
Feature/sponsored transactions #1468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
td202
wants to merge
33
commits into
p10
Choose a base branch
from
feature/sponsored-transactions
base: p10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* COR-1980: update SendBlockItemRequest::get_v0_format This adds the new implementations for - BlockItem::AccountTransactionV1 - BlockItem::RawBlockItem * update CHANGELOG * Update concordium-node/src/grpc2.rs Co-authored-by: Søren Bruus Zeppelin <[email protected]> * Update concordium-node/src/grpc2.rs Co-authored-by: Søren Bruus Zeppelin <[email protected]> * fix compilation * simplify `TryFrom<AccountTransactionV1Signatures` implementation * Update concordium-node/src/grpc2.rs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * concordium-base: update submodule * add stub for missing transaction verifier implementation * format * fix Versioned::from(0) This doesn't compile unfortunately. --------- Co-authored-by: drsk <[email protected]> Co-authored-by: Søren Bruus Zeppelin <[email protected]> Co-authored-by: Thomas Dinsdale-Young <[email protected]>
Add transaction verification results for sponsored transactions.
* SPO-9: extend AccountTransactionDetails This extacts the optional sponsor from the received transaction and fills the new sponsor field of `AccountTransactionDetails`. * update CHANGELOG * concordium-base:submodule update * set TransactionSummaryVersion ~ TransactionOutcomesVersion * concordium-base: update submodule * propagate changes of concordium-base * update benchmark code * update getResults * fix assertApplied * extend hash tests for TOV3 * fix transactionOutcomesHashV1 * concordium-base: update submodule * Update concordium-consensus/benchmarks/transactions/SchedulerBench/Helpers.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/GlobalState/BlockState.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/Types/TransactionOutcomes.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/Types/TransactionOutcomes.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/Scheduler.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/GlobalState/BlockState.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * remove changelog entry * format * fix tests/benchmark * drop tsSponsorField logic from scheduler * Apply suggestion from @td202 Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Apply suggestion from @td202 Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Apply suggestion from @td202 Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Apply suggestion from @td202 Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Apply suggestion from @td202 Co-authored-by: Thomas Dinsdale-Young <[email protected]> * small fixes after suggestions * added DataKinds pragma * more review comments * format * cosmetics * format * fix a billion tests * Update concordium-consensus/src/Concordium/Scheduler/Environment.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/Scheduler.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * remove wtcSponsorDetails field --------- Co-authored-by: drsk <[email protected]> Co-authored-by: Thomas Dinsdale-Young <[email protected]>
|
The file size of the WebAssembly PLT deployment unit is 277268B. |
* SPO-10: transaction verifier implementation * one passing test with valid transaction data * transaction verifier tests * fix transaction verifier the signature verifiaction for sponsored transactions is different from the signature verifaction of normal transactions. * clean up * Update concordium-consensus/src/Concordium/TransactionVerification.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/tests/consensus/ConcordiumTests/KonsensusV1/TransactionProcessingTest.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * Update concordium-consensus/src/Concordium/TransactionVerification.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * concordium-base: update submodule * Update concordium-consensus/src/Concordium/TransactionVerification.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]> * update call to verifySponsoredTransaction * set unused type family instances to Void * factor out sender/sponsor signatures * update minimal energy amount in tests * add EnergyRate to test data * update minimum nonce * introduce `checkExactNonce` field in test data * add test for succeeding tx when checkExactNonce == False * remove test .dat file * Add a test for NormalTransactionDuplicateNonce error case * refactor test data creation * incremented nonce, so no zero nonce appear in the tests * cosmetics * replace dummy type family * add comment * format --------- Co-authored-by: drsk <[email protected]> Co-authored-by: Thomas Dinsdale-Young <[email protected]>
…ctions' into sponsored-transactions-execution-charging
…tion-charging Sponsored transactions execution charging
(Hopefully) fix Windows build signing on windows-latest.
…ctions Test Sponsored Transaction Execution
Add haskell code coverage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
_Describe the purpose of the pull request, link to issue describing the problem, etc.
Changes
_Describe the changes that were needed.
Checklist
hard-to-understand areas.
CLA acceptance
_Remove if not applicable.
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.