-
Notifications
You must be signed in to change notification settings - Fork 55
feat: configurable cohere processors destination #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work! added some small nitpicks nothing too big
|
||
ref, err := refRes.Resolve(r) | ||
if err != nil { | ||
return cerrors.Errorf("error reference resolver: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return cerrors.Errorf("error reference resolver: %w", err) | |
return cerrors.Errorf("error resolving reference: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Fixes #2231
Quick checks