feat: configurable cohere processors destination #2235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maha-hajja
reviewed
May 6, 2025
| @@ -113,6 +116,12 @@ func (p *EmbedProcessor) Open(ctx context.Context) error { | |||
| } | |||
| p.inputFieldRefResolver = &inputResolver | |||
|
|
|||
| outputResolver, err := sdk.NewReferenceResolver(p.config.OutputField) | |||
| if err != nil { | |||
| return cerrors.Errorf(`failed to create a field resolver for %v parameter: %w`, p.config.OutputField, err) | |||
There was a problem hiding this comment.
Suggested change
| return cerrors.Errorf(`failed to create a field resolver for %v parameter: %w`, p.config.OutputField, err) | |
| return cerrors.Errorf("failed to create a field resolver for %v parameter: %w", p.config.OutputField, err) |
| @@ -33,7 +33,7 @@ func ExampleCommandProcessor() { | |||
| Summary: `Generate responses using Cohere's command model`, | |||
| Description: ` | |||
| This example demonstrates how to use the Cohere command processor to generate responses for a record's ` + "`.Payload.After`" + ` field. | |||
| The processor sends the input text to the Cohere API and replaces it with the model's response.`, | |||
| The processor sends the input text from the configured "request.body" to the Cohere API and stores the model's response into the configured "response.body"`, | |||
There was a problem hiding this comment.
is this what we meant here?
Suggested change
| The processor sends the input text from the configured "request.body" to the Cohere API and stores the model's response into the configured "response.body"`, | |
| The processor sends the input text from the configured "inputField" to the Cohere API and stores the model's response into the configured "outputField"`, |
There was a problem hiding this comment.
The embed processor currently uses inputField/outputField for the same purpose as request.body/response.body in rerank and command processors. That's why it is like this.
| @@ -53,7 +53,9 @@ type embedProcConfig struct { | |||
| // The maximum waiting time before retrying. | |||
| BackoffRetryMax time.Duration `json:"backoffRetry.max" default:"5s"` | |||
| // Specifies the field from which the request body should be created. | |||
| InputField string `json:"inputField" validate:"regex=^\\.(Payload|Key).*" default:".Payload.After"` | |||
| InputField string `json:"inputField" default:".Payload.After"` | |||
| // OutputField specifies in which field should the response body be saved. | |||
There was a problem hiding this comment.
Suggested change
| // OutputField specifies in which field should the response body be saved. | |
| // OutputField specifies which field will the response body be saved at. |
|
|
||
| ref, err := refRes.Resolve(r) | ||
| if err != nil { | ||
| return cerrors.Errorf("error reference resolver: %w", err) |
There was a problem hiding this comment.
Suggested change
| return cerrors.Errorf("error reference resolver: %w", err) | |
| return cerrors.Errorf("error resolving reference: %w", err) |
|
|
||
| err = ref.Set(data) | ||
| if err != nil { | ||
| return cerrors.Errorf("error reference set: %w", err) |
There was a problem hiding this comment.
Suggested change
| return cerrors.Errorf("error reference set: %w", err) | |
| return cerrors.Errorf("error setting reference: %w", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2231
Quick checks