[arch-v2] Fix processor task handling filtered records #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
reviewed
May 12, 2025
raulb
approved these changes
May 16, 2025
* fix destination task handling of filtered records * destination task tests * refactor task ordering using TaskNode (#2287)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the processor task handling filtered records in the v2 architecture.
I added aTODOcomment for the destination task that can experience a similar problem when handling batches that include filtered records. That part will be done in a separate PR to keep the changes small and easily reviewable.This now also includes the work from 2 other PRs:
funnel.Orderwithfunnel.TaskNode#2287Fixes #2257
Quick checks