fix(deps): pin thrift to v0.22.0 to unbreak the 32-bit release build#2515
Merged
Conversation
Update the .deb/.rpm install-command examples to reference v0.15.0 for the release (release-checklist documentation step). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…guard The v0.15.0 release build failed: apache/thrift v0.23.0 uses math.MaxUint32 as an untyped int constant in framed_transport.go, which overflows int on 32-bit architectures. GoReleaser cross-compiles a linux/386 (i386) artifact, so the build broke at release time. Regular CI only builds on 64-bit, so it wasn't caught. thrift is an indirect dependency (built-in S3 connector -> parquet-go -> thrift); the v0.16 -> v0.23 bump in the Go 1.25 refresh wasn't required. Pin it back to v0.22.0, which compiles on 32-bit and satisfies parquet-go. Verified `GOOS=linux GOARCH=386 go build ./...` passes and 64-bit build/tests are unchanged. Add a build (linux/386) job to the test workflow so a 32-bit-only compile failure is caught in CI instead of during a release (postmortem follow-up: this reached the release process). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.15.0 release build failed on this. Fixes the release blocker.
What broke
GoReleaser cross-compiles a linux/386 (i386) artifact.
apache/thrift v0.23.0usesmath.MaxUint32as an untypedintconstant inframed_transport.go:206, which overflowsinton 32-bit architectures:Regular CI only builds on 64-bit (amd64/arm64), so this stayed latent until the release cross-compiled for 386.
Fix
thriftis an indirect dependency (built-in S3 connector →parquet-go→ thrift). Thev0.16 → v0.23bump in the Go 1.25 refresh (#2507) wasn't required — pin it back to v0.22.0, which compiles on 32-bit and satisfies parquet-go's requirement. VerifiedGOOS=linux GOARCH=386 go build ./...passes and 64-bit build/tests are unchanged.Guard (postmortem follow-up)
This reached the release process, so per the postmortem discipline it gets a new automated check: a
build (linux/386)job intest.ymlthat cross-compiles for the 32-bit release target, so a 32-bit-only compile failure is caught in CI instead of during a release. The job passing on this PR is the proof the fix works.Risk tier
Tier 2 (dependency + CI). No functional change — a thrift patch-level downgrade on the parquet path; behavior unchanged.
Note on v0.15.0
The
v0.15.0tag was created but its Release workflow failed, so no GitHub release or artifacts were published. Once this merges, the tag needs to be re-cut on the fixedmain.🤖 Generated with Claude Code