Skip to content

feat: add blocktest subcommand to evm-spec-tester #3206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025

Conversation

Pana
Copy link
Member

@Pana Pana commented May 9, 2025

The default command change to statetest subcommand.
The blocktest command real logic will be in next PR


This change is Reviewable

@Pana Pana requested a review from ChenxingLi May 9, 2025 07:45
Copy link
Contributor

@ChenxingLi ChenxingLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion


tests/extra-test-toolkits line 1 at r1 (raw file):

Subproject commit f0a4feafd70334a0d34f6e49ba2973715fb66666

Incorrect version (2 years ago)

Copy link
Member Author

@Pana Pana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 1 unresolved discussion (waiting on @ChenxingLi)


tests/extra-test-toolkits line 1 at r1 (raw file):

Previously, ChenxingLi (Chenxing Li) wrote…

Incorrect version (2 years ago)

Done.

ChenxingLi
ChenxingLi previously approved these changes May 12, 2025
Copy link
Contributor

@ChenxingLi ChenxingLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 12 of 14 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Pana)

@Pana
Copy link
Member Author

Pana commented May 13, 2025

retest this please

1 similar comment
@Pana
Copy link
Member Author

Pana commented May 13, 2025

retest this please

Copy link
Contributor

@ChenxingLi ChenxingLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Pana)

@Pana Pana merged commit d508aaa into Conflux-Chain:master May 13, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants