fix Windows build by upgrading vergen to vergen-git2 #3361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
retest this please |
peilun-conflux
approved these changes
Dec 22, 2025
Contributor
peilun-conflux
left a comment
peilun-conflux
left a comment
There was a problem hiding this comment.
@peilun-conflux reviewed 8 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @iosh).
peilun-conflux
pushed a commit
that referenced
this pull request
Dec 23, 2025
fix Windows build by upgrading vergen to vergen-git2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade form vergen v8 to vergen-git2 to fix Windows build error （Windows build does not link with Advapi32.lib:
https://github.com/rust-lang/git2-rs/issues/1142).This change is