Lq all in 1#565
Open
lorenaqendro wants to merge 3 commits into
Open
Conversation
Contributor
arya-hemanshu
left a comment
arya-hemanshu
left a comment
There was a problem hiding this comment.
Tested by cloning the branch, and it works fine. Tested building DC and running some recipes. Also tested running some python recipes and they also worked fine.
Looks good to me. Once @thanosbnt review is done, i think it is good to merge
Contributor
|
I'm not sure if this works with qgis as i have to place the plugin at a specific directory...This means cloning the whole repo in the qgis folder, locating the plugin and copying over to the right directory. Not sure how i could do it... |
Contributor
Author
|
@thanosbnt do you think a symlink to the qgis plugin on the repo would do? |
Contributor
|
Never used this, we could try it out |
Contributor
Author
|
Yes, let's try together tomorrow and see if it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Incorporated in the repo the python support and qgis plugin.
Checklist