Skip to content

Commit 55f5dc7

Browse files
authored
[DBMON-5479] Add database_instance to mysql_variables event (DataDog#20620)
* Add database_instance to mysql_variables event * add changelog
1 parent edea5a6 commit 55f5dc7

3 files changed

Lines changed: 3 additions & 0 deletions

File tree

mysql/changelog.d/20620.fixed

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixes missing mysql variables from database instances configured with templated names

mysql/datadog_checks/mysql/metadata.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ def report_mysql_metadata(self):
173173
settings = [dict(row) for row in rows]
174174
event = {
175175
"host": self._check.reported_hostname,
176+
"database_instance": self._check.database_identifier,
176177
"agent_version": datadog_agent.get_version(),
177178
"dbms": "mysql",
178179
"kind": "mysql_variables",

mysql/tests/test_metadata.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ def test_collect_mysql_settings(aggregator, dbm_instance, dd_run_check):
7272
event = next((e for e in dbm_metadata if e['kind'] == 'mysql_variables'), None)
7373
assert event is not None
7474
assert event['host'] == "stubbed.hostname"
75+
assert event['database_instance'] == "stubbed.hostname"
7576
assert event['dbms'] == "mysql"
7677
assert len(event["metadata"]) > 0
7778

0 commit comments

Comments
 (0)