[pull] master from DataDog:master - #177
Merged
Merged
Conversation
… restarts (#21577) * Fix config_set_persistent_cache_id hashing to be satable between processes * Move the tests to the proper place in test_utils.py * Fix persistent cache tests using the updated method * Ensure that by default we do a secure hashing and provide ways to select our hashing method * Update test hash values after udpating the hashing algorithm * Update changelog description * Ensure that when fips is enabled, sha256 is used instead even if secure is set to False * Clarify method docstring * Harden tests by explicitely setting the lenght * Remove secure option to ensure no grey area on fips compliance * Remove unused imports * Remove length argument * Fix test after having removed the length argument * Address PR comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )