[pull] master from DataDog:master - #366
Merged
Merged
Conversation
* add legacy field for integrations * add coredns
* collect is physical from cisco aci * add test * fix test
* Improve license parsing * Add changelog * fix(licenses): Fix validation of SPDX identifiers containing -or- and -and- - Update _OP_SPLIT regex to use negative lookbehind/lookahead assertions - Prevent matching "-or-" or "-and-" inside identifiers like "GPL-2.0-or-later" - Fix fallback logic to check per-chunk instead of entire parts list - Ensure all license identifiers are extracted from compound expressions Rationale: The _OP_SPLIT regex was incorrectly splitting SPDX identifiers like GPL-2.0-or-later into fragments (GPL-2.0- and -later) because \bOR\b with re.IGNORECASE matched the lowercase "or" between hyphens. This caused valid licenses with -or-later or -and- segments to be rejected by ddev validate licenses. Additionally, the fallback logic bug prevented proper extraction of multiple license identifiers from compound expressions, resulting in only the first identifier being extracted. This commit made by [/dd:git:commit:atomic](https://github.com/DataDog/claude-marketplace/tree/main/dd/commands/git/commit/atomic.md) * Add type hint to parts * fix(licenses): Remove comma as a separator in license expressions - Remove comma from _OP_SPLIT regex separator list - Fixes incorrect splitting of license names containing commas - Addresses validation failures for licenses like "Apache License, Version 2.0" Rationale: Commas are not part of the SPDX expression syntax (only AND, OR, and WITH are valid operators). When commas appear in license strings, they are part of the license name itself, not expression separators. The previous implementation incorrectly split "Apache License, Version 2.0" into ["Apache License", "Version 2.0"], causing validation failures. This commit made by [/dd:git:commit:atomic](https://github.com/DataDog/claude-marketplace/tree/main/dd/commands/git/commit/atomic.md)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )