[pull] master from DataDog:master - #407
Merged
Merged
Conversation
* Add PR reference to dependency resolution follow-up PRs * Fix: use github.rest.repos namespace for listPullRequestsAssociatedWithCommit * Fix: parse PR number from merge commit message instead of using API lookup * Test against known master merge commit instead of synthetic PR commit * Remove test job * Ensure Docker is running before build steps on Windows
* [sqlserver] Fix procedure_name missing from query metrics when monitoring user lacks CONNECT on user database `OBJECT_NAME(sproc_object_id, dbid)` returns NULL when the Datadog monitoring user does not have a CONNECT grant on the user database, causing `is_proc` to evaluate to False and silently dropping the procedure_name tag from all query metrics rows. Fix by using `sproc_object_id` — which is populated by the LEFT JOIN to `sys.dm_exec_procedure_stats` regardless of DB-level permissions — as a permission-independent signal that a statement belongs to a stored procedure. When `OBJECT_NAME()` returns NULL, fall back to extracting the procedure name from the obfuscated procedure text via the obfuscator metadata. This restores the behaviour that existed prior to 7.66.0 and also fixes the same gap for the `NO_AGGREGATES` query path. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * [sqlserver] add unit test to prevent anymore regression on missing procedure name * add changelog entry for the fix --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Naji Astier <naji.astier@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )