[pull] master from DataDog:master - #421
Merged
Merged
Conversation
* Fix kafka_actions timeout when reading latest N messages When start_offset=-1 (latest), the consumer was positioned at OFFSET_END, causing it to only see new messages and time out when no new messages arrived. Now queries watermark offsets and seeks back from the high watermark to read the last N existing messages. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add changelog entry for kafka_actions offset fix Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fetch watermark offsets concurrently to respect global timeout get_watermark_offsets only accepts a single partition, so fetch all partitions in parallel via ThreadPoolExecutor. Both the per-call timeout and the as_completed fence are derived from the remaining global timeout budget, preventing the watermark phase from exceeding timeout_ms on topics with many partitions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use offsets_for_times to fetch all watermarks in a single call Replace per-partition get_watermark_offsets with a single consumer.offsets_for_times() call that resolves high watermarks for all partitions at once, matching the pattern used by kafka_consumer. This removes the threading overhead and respects the global timeout budget. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use get_watermark_offsets with remaining timeout budget Replace offsets_for_times with get_watermark_offsets, using the remaining global timeout budget as the per-call timeout so the watermark phase cannot exceed timeout_ms overall. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Simplify watermark fetch to use fixed timeout Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Use AdminClient.list_offsets to fetch all watermarks in one call Replace per-partition get_watermark_offsets loop with a single AdminClient.list_offsets() call using OffsetSpec.latest(), which fetches high watermarks for all partitions in one batched broker request. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Add unit tests for consume_messages offset handling Test that: - start_offset=-1 calls AdminClient.list_offsets to resolve high watermarks - Multiple partitions are fetched in a single list_offsets call - Seek offset is clamped to 0 when high watermark < max_messages - start_offset=-2 (earliest) does not call list_offsets Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Simplify offset handling test to a single focused test Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
* Add dataflows to agent integrations * amazon_app_mesh doesn't emit events * Consul events collection can be disabled via config * container doesn't emit events * containerd events are not always_on * elastic events are not always_on * cloud_foundry_api events * couchbase dataflows * Fix dataflow ids * amazon_app_mesh has no metrics * appgate_sdp has no logs * checkpoint_harmony_endpoint has no metrics * fluxcd has logs * docker_daemon events are not always_on * celery doesn't have logs * Add cloudera events dataflows * Make dataflow id unique * remove logs dataflows from eks_fargate Co-authored-by: Jon Rosario <jon.rosario@datadoghq.com> --------- Co-authored-by: Jon Rosario <jon.rosario@datadoghq.com>
…22846) * [MOPU-288] Improve NGINX monitor messages with full runbook template Add structured alert messages to all three NGINX upstream monitor templates (4xx errors, 5xx errors, upstream peer failures) following the system monitor style: What's happening, Impact, Runbook with cause/resolution table, related links, and notification placeholder. Includes Datadog template variables (value, threshold, first_triggered_at, triggered_duration_sec). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * [MOPU-288] Add conditional alert/warning/recovery blocks to NGINX monitor messages Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Add permanent bypass annotation for global-timestamp-format-in-sample-checks on beyondtrust_privileged_remote_access so CI stays green. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )