Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions clickhouse/assets/configuration/spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ files:
secret: true
value:
type: string
display_default: ''
- name: db
description: The database to connect to.
fleet_configurable: true
Expand Down
1 change: 1 addition & 0 deletions clickhouse/changelog.d/23015.fixed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix authentication regression where a missing `password` config option defaults to `None` instead of an empty string, causing ClickHouse to reject connections with error code 194.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ def instance_only_custom_queries():
return False


def instance_password():
return ''


def instance_port():
return 8123

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ instances:
#
# username: default

## @param password - string - optional
## @param password - string - optional - default:
## The password of `username`.
#
# password: <PASSWORD>
Expand Down
27 changes: 27 additions & 0 deletions clickhouse/tests/test_unit.py
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,30 @@ def test_missing_server_config():
# The error should be in the validation result
assert not check._validation_result.valid
assert any('server' in str(error).lower() for error in check._validation_result.errors)


def test_connect_no_password_uses_empty_string():
"""
Regression test: when no password is configured, connect() must pass password=''
not password=None. clickhouse_connect encodes None as the literal string 'None'
in the Authorization header, causing ClickHouse error code 194 (auth failure).
"""
instance = {
'server': 'localhost',
'port': 8123,
'username': 'default',
# 'password' intentionally omitted
}
check = ClickhouseCheck('clickhouse', {}, [instance])
check.check_id = 'test-no-password'

assert check._config.password == '', (
"password must default to '' — None causes auth error 194 in clickhouse_connect"
)

with mock.patch('clickhouse_connect.get_client') as m:
mock_client = mock.MagicMock()
m.return_value = mock_client
check.connect()
_, kwargs = m.call_args
assert kwargs['password'] == '', "connect() must pass password='' not password=None to clickhouse_connect"
2 changes: 1 addition & 1 deletion control_m/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -179,4 +179,4 @@ Need help? Contact [Datadog support][8].
[7]: https://github.com/DataDog/integrations-core/blob/master/control_m/metadata.csv
[8]: https://docs.datadoghq.com/help/
[9]: https://docs.datadoghq.com/metrics/types/?tab=histogram
[10]: https://github.com/DataDog/datadog-agent/blob/main/pkg/config/config_template.yaml#L210-L227
[10]: https://github.com/DataDog/datadog-agent/blob/3697d3b93bde62e2c3bf039e170ce69e49ef5294/pkg/config/config_template.yaml#L225-L242
6 changes: 6 additions & 0 deletions datadog_checks_base/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

<!-- towncrier release notes start -->

## 37.33.0 / 2026-03-20

***Added***:

* Add support for require_trusted_provider security validation ([#22226](https://github.com/DataDog/integrations-core/pull/22226))

## 37.32.0 / 2026-03-18

***Added***:
Expand Down
1 change: 0 additions & 1 deletion datadog_checks_base/changelog.d/22226.added

This file was deleted.

2 changes: 1 addition & 1 deletion datadog_checks_base/datadog_checks/base/__about__.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# (C) Datadog, Inc. 2018-present
# All rights reserved
# Licensed under a 3-clause BSD style license (see LICENSE)
__version__ = "37.32.0"
__version__ = "37.33.0"
3 changes: 2 additions & 1 deletion datadog_checks_downloader/tests/test_downloader.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@
"datadog-amazon-kafka", # excluding this since `amazon-kafka` wasn't an official release
"datadog-tokumx", # excluding this since `tokumx` was dropped in py3
"datadog-ntp", # excluding this since `ntp` was Agent 5 only
"datadog-kaspersky", # excluding this since `kaspersky` check was removed and wheel no longer exists
"datadog-kaspersky", # excluding this since `kaspersky` check was removed and wheel is not available
"datadog-trend-micro-cloud-one", # excluding this since the check was removed and wheel is not available
]

EXCLUDED_LOG_INTEGRATIONS = [
Expand Down
14 changes: 7 additions & 7 deletions gpu/metadata.csv
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ gpu.decoder_utilization,gauge,16,percent,,Percentage of time the decoder was act
gpu.device.total,gauge,16,,,Number of GPU devices found in the host,0,gpu,device.total,,
gpu.dram_active,gauge,16,percent,,Percentage of time the DRAM was active,0,gpu,dram_active,,
gpu.encoder_utilization,gauge,16,percent,,Percentage of time the encoder was active,0,gpu,encoder_utilization,,
gpu.errors.ecc.corrected.total,gauge,16,,,Total count of corrected ECC errors,0,gpu,errors.ecc.corrected.total,,
gpu.errors.ecc.uncorrected.total,gauge,16,,,Total count of uncorrected ECC errors,0,gpu,errors.ecc.uncorrected.total,,
gpu.errors.xid.total,gauge,16,,,Total count of Xid errors,0,gpu,errors.xid.total,,
gpu.errors.ecc.corrected.total,gauge,16,,,"Corrected ECC (Error Correcting Code) errors indicate GPU memory corruption that was detected and successfully corrected by the hardware. While these errors do not immediately impact application correctness, recurring corrected errors can be an early sign of degrading memory or underlying hardware issues.",0,gpu,errors.ecc.corrected.total,,
gpu.errors.ecc.uncorrected.total,gauge,16,,,"Uncorrectable ECC (Error Correcting Code) errors indicate GPU memory corruption that could not be automatically fixed. These errors can lead to data corruption, application crashes, or incorrect computation results.",0,gpu,errors.ecc.uncorrected.total,,
gpu.errors.xid.total,gauge,16,,,XID errors are NVIDIA driver error codes that indicate GPU hardware or software issues like thermal throttling to hardware defects. Investigate these errors immediately as they often precede total GPU failures.,0,gpu,errors.xid.total,,
gpu.fan_speed,gauge,16,percent,,Configured fan speed as a percentage of its maximum,0,gpu,fan_speed,,
gpu.fp16_active,gauge,16,percent,,Percentage of the time that the 16-bit floating point calculation engine was active. Only for Hopper and newer GPUs,0,gpu,fp16_active,,
gpu.fp32_active,gauge,16,percent,,Percentage of the time that the 32-bit floating point calculation engine was active. Only for Hopper and newer GPUs,0,gpu,fp32_active,,
Expand All @@ -45,10 +45,10 @@ gpu.nvlink.errors.recovery,gauge,16,,,NVLink recovery error counter total for al
gpu.nvlink.errors.replay,gauge,16,,,NVLink replay error counter total for all links,0,gpu,nvlink.errors.replay,,
gpu.nvlink.nvswitch_connected,gauge,16,,,Number of NVLinks connected to the NVSwitch,0,gpu,nvlink.nvswitch_connected,,
gpu.nvlink.speed,gauge,16,megabit,second,common speed of all NVLINK links,0,gpu,nvlink.speed,,
gpu.nvlink.throughput.data.rx,gauge,16,kilobyte,second,RX data throughput of all NVLINK links,0,gpu,nvlink.throughput.data.rx,,
gpu.nvlink.throughput.data.tx,gauge,16,kilobyte,second,TX data throughput of all NVLINK links,0,gpu,nvlink.throughput.data.tx,,
gpu.nvlink.throughput.raw.rx,gauge,16,kilobyte,second,RX raw throughput of all NVLINK links,0,gpu,nvlink.throughput.raw.rx,,
gpu.nvlink.throughput.raw.tx,gauge,16,kilobyte,second,TX raw throughput of all NVLINK links,0,gpu,nvlink.throughput.raw.tx,,
gpu.nvlink.throughput.data.rx,gauge,16,kilobyte,second,Total RX data throughput of all NVLINK links,0,gpu,nvlink.throughput.data.rx,,
gpu.nvlink.throughput.data.tx,gauge,16,kilobyte,second,Total TX data throughput of all NVLINK links,0,gpu,nvlink.throughput.data.tx,,
gpu.nvlink.throughput.raw.rx,gauge,16,kilobyte,second,Total RX of all NVLINK links,0,gpu,nvlink.throughput.raw.rx,,
gpu.nvlink.throughput.raw.tx,gauge,16,kilobyte,second,Total TX of all NVLINK links,0,gpu,nvlink.throughput.raw.tx,,
gpu.pci.replay_counter,gauge,16,,,PCI replay counter,0,gpu,pci.replay_counter,,
gpu.pci.throughput.rx,gauge,16,byte,second,Bytes received through PCI to the GPU device per second,0,gpu,pci.throughput.rx,,
gpu.pci.throughput.tx,gauge,16,byte,second,Bytes transmitted through PCI from the GPU device per second,0,gpu,pci.throughput.tx,,
Expand Down
2 changes: 1 addition & 1 deletion requirements-agent-release.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ datadog-ceph==4.4.0; sys_platform != 'win32'
datadog-cert-manager==6.3.0
datadog-checkpoint-harmony-endpoint==1.2.0
datadog-checkpoint-quantum-firewall==1.3.0
datadog-checks-base==37.32.0
datadog-checks-base==37.33.0
datadog-checks-dependency-provider==3.2.0
datadog-checks-downloader==9.1.0
datadog-cilium==6.3.0
Expand Down
Loading