[pull] master from DataDog:master - #694
Merged
Merged
Conversation
* fix(ibm_mq): avoid ZeroDivisionError when queue max depth is 0 * Rename changelog to match PR number
#24517) * Add initial scaffolding for async insert buffer snapshot collection * Add async insert buffer snapshot to config spec * Add async insert buffer snapshot config defaults and validation * Register async insert buffer gauge metrics in metadata * Add async insert buffer snapshot collection job and metrics * Wire async insert buffer snapshot job * Remove async insert buffer gauge metrics from metadata * Update spec.yaml to match design * Wire async insert buffer snapshot into query samples * Set up config for async insert buffer snapshot * Add async insert buffer snapshot collection to query samples job * Add changelog entry for async insert buffer snapshot * Add expected defaults for async insert buffer snapshot config * Fix buffer snapshot and query samples coupling * Use GCD to schedule buffer snapshot and query samples collection * Add unit tests for async insert buffer snapshot collection * Add to comment to explain why we collapse collection into query samples * Rename buffer field oldest_entry_us to flush_deadline_us * Use a single time.time() call in buffer snapshot collection * Use dedicated error metric for buffer snapshot collection * Use single time.time call in sample collection * Add type hints to new methods in statement_samples * Add mirror test for buffer snapshot collection interval * Fix zero division error from fractional collection intervals * Detect unknown table error and log as single warning + skip * Fix incorrect description for buffer snapshot config * Rename asynchronous_insert_buffer_snapshot config to collect_pending_async_inserts * Rename payload_row_limit to max_samples_per_collection and add integer greater than 0 validation * Add dd.clickhouse.async_inserts_buffer metrics to track the size of returned data * Remove bytes_submitted metric from async_inserts_buffer * Send buffer snapshot on the dbm-metrics track * Add server clock to buffer snapshot query * Skip buffer snapshots when the async inserts table is unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )