Add wayfinding and related rendering options#51
Open
ETcodehome wants to merge 44 commits intoConorLeckey:masterfrom
Open
Add wayfinding and related rendering options#51ETcodehome wants to merge 44 commits intoConorLeckey:masterfrom
ETcodehome wants to merge 44 commits intoConorLeckey:masterfrom
Conversation
fe4ee0f to
0a27e64
Compare
…Mode into etaylor_wayFinding
…an-Mode into etaylor_wayFinding
Contributor
Author
|
@ConorLeckey @sram1337 I've been running this in parallel with all the other work we've been doing because I found the wayfinding QoL and diagnostics so useful along the way, so it's been kept in good order as other changes have progressed. The screenshots above are a little outdated as things like group tile config options were also added. I think it'd be good to get this one merged to avoid conflicts with any sailing fix as there is (admittedly) a bit of complexity in this change set that could potentially lead to conflicts. Once this is merged I'll start looking at addressing sailing issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR address?
While playing tileman mode with auto mark on, a frequent source of frustration is that the player can't reliably move along an already claimed path without accidentally claiming a new tile. Additionally, the cost in tiles to move to where you've currently selected is not clear before starting to claim a path.
How does it address the issue
This PR:
Feature screenshots (varying example configurations)
New config menu settings:

Walking a claimed path (claim tiles set to inset)

Walking an unclaimed path (example custom configuration)

Testing performed
Edge case handling explanations
The wayfinding rendering is disabled when shift is held
Sometimes I can't wayfind very far in front of me
Paths to an interactable object don't show
Risk Analysis
Annoying existing plugin users
Performance implications of path rendering