This repository was archived by the owner on Mar 11, 2024. It is now read-only.
fix: fixed to compile on Electron 13 (re-opened the pull request on a feature branch)#3
Open
ptesavol wants to merge 1 commit intoConsenSys-archive:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes it possible to build the binaries for Electron 13. You can try it out by running
./node_modules/.bin/electron-rebuild -v 13Deprecated ArrayBuffer methods have been removed from the v8.h used by Electron 13, and this prevented the previous version of this lib from compiling for Electron 13. The changes in this pull request have been made according to my current understanding of this document https://docs.google.com/document/d/1sTc_jRL87Fu175Holm5SV0kajkseGl2r8ifGY76G35k/edit#heading=h.5irk4csrpu0y and have not been tested for memory leaks nor performance.