Skip to content

feat: remove l2-node in e2e test and make it to run in local stack op… #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 22, 2025

Conversation

jonesho
Copy link
Contributor

@jonesho jonesho commented May 14, 2025

…tionally

This PR implements issue(s) #991

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jonesho jonesho self-assigned this May 14, 2025
@jonesho jonesho temporarily deployed to docker-build-and-e2e May 14, 2025 07:45 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.48%. Comparing base (ffca1da) to head (06e5bcf).

Files with missing lines Patch % Lines
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 0.00% 3 Missing ⚠️
...lin/net/consensys/zkevm/ethereum/AccountManager.kt 0.00% 1 Missing ⚠️
.../contract/ContractDeploymentBlockNumberProvider.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1001      +/-   ##
============================================
- Coverage     66.49%   66.48%   -0.01%     
  Complexity     1133     1133              
============================================
  Files           322      322              
  Lines         12997    13000       +3     
  Branches       1355     1357       +2     
============================================
+ Hits           8642     8643       +1     
- Misses         3791     3792       +1     
- Partials        564      565       +1     
Flag Coverage Δ *Carryforward flag
hardhat 98.51% <ø> (ø) Carriedforward from 505eac6
kotlin 63.98% <28.57%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../zkevm/coordinator/app/config/CoordinatorConfig.kt 77.09% <100.00%> (+0.30%) ⬆️
...lin/net/consensys/zkevm/ethereum/AccountManager.kt 70.76% <0.00%> (ø)
.../contract/ContractDeploymentBlockNumberProvider.kt 0.00% <0.00%> (ø)
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 1.47% <0.00%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jonesho jonesho temporarily deployed to docker-build-and-e2e May 14, 2025 08:00 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the feat/remove-geth-l2-node branch from f0dd3e9 to e13cf1c Compare May 15, 2025 07:24
@jonesho jonesho temporarily deployed to docker-build-and-e2e May 15, 2025 07:24 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the feat/remove-geth-l2-node branch from e13cf1c to d9983d8 Compare May 15, 2025 14:48
@jonesho jonesho temporarily deployed to docker-build-and-e2e May 15, 2025 14:49 — with GitHub Actions Inactive
@jonesho jonesho requested a review from a team May 15, 2025 17:59
@jonesho jonesho force-pushed the feat/remove-geth-l2-node branch from d9983d8 to 970ffbe Compare May 19, 2025 18:06
@jonesho jonesho temporarily deployed to docker-build-and-e2e May 19, 2025 18:07 — with GitHub Actions Inactive
@jonesho jonesho requested review from a team and removed request for a team May 21, 2025 08:08
@jonesho jonesho temporarily deployed to docker-build-and-e2e May 22, 2025 05:13 — with GitHub Actions Inactive
@jonesho jonesho had a problem deploying to docker-build-and-e2e May 22, 2025 06:31 — with GitHub Actions Error
@jonesho jonesho temporarily deployed to docker-build-and-e2e May 22, 2025 06:37 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e May 22, 2025 06:49 — with GitHub Actions Inactive
@jonesho jonesho requested a review from fluentcrafter May 22, 2025 06:53
@jonesho jonesho merged commit 7e306e2 into main May 22, 2025
21 checks passed
@jonesho jonesho deleted the feat/remove-geth-l2-node branch May 22, 2025 15:27
thedarkjester pushed a commit that referenced this pull request Jun 4, 2025
#1001)

* feat: remove l2-node in e2e test and make it to run in local stack optionally

* fix: l2 spec transaction data size limit e2e test

* feat: revise blockscout configs

* feat: revised comment in Makefile

* feat: update transaction-exclusion-api and postman image

* feat: remove expected-traces-api-version-v2 from coordinator local overrides toml

* feat: remove shomei-frontend from ci and add disabled option in Type2StateProofProviderConfig

* feat: add endpoint for type2-state-proof-provider

* feat: revise coordinator local-dev override configs

* feat: remove white space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants