Skip to content

coordinator: adds config v2 #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Conversation

fluentcrafter
Copy link
Contributor

@fluentcrafter fluentcrafter commented Apr 8, 2025

This PR implements issue(s) #922

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 58.01105% with 608 lines in your changes missing coverage. Please review.

Project coverage is 66.71%. Comparing base (86f9bbf) to head (dc6a9ec).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 0.00% 281 Missing ⚠️
...a/coordinator/config/v2/toml/ConfigLoaderHelper.kt 50.64% 34 Missing and 4 partials ⚠️
...nea/coordinator/config/v2/toml/SignerConfigToml.kt 54.68% 11 Missing and 18 partials ⚠️
...kotlin/linea/coordinator/config/v2/SignerConfig.kt 40.00% 22 Missing and 2 partials ⚠️
...lin/linea/coordinator/config/v2/toml/ProverToml.kt 61.29% 22 Missing and 2 partials ⚠️
...ea/coordinator/config/v2/MessageAnchoringConfig.kt 57.14% 14 Missing and 7 partials ⚠️
...nator/config/v2/toml/MessageAnchoringConfigToml.kt 78.08% 7 Missing and 9 partials ⚠️
...kotlin/linea/coordinator/config/v2/ProverConfig.kt 0.00% 14 Missing ⚠️
...act/l2/Web3JL2MessageServiceSmartContractClient.kt 0.00% 14 Missing ⚠️
...ea/coordinator/config/v2/toml/decoders/Decoders.kt 55.55% 6 Missing and 6 partials ⚠️
... and 31 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #853      +/-   ##
============================================
+ Coverage     66.51%   66.71%   +0.19%     
- Complexity     1135     1177      +42     
============================================
  Files           324      360      +36     
  Lines         12994    14203    +1209     
  Branches       1356     1463     +107     
============================================
+ Hits           8643     9475     +832     
- Misses         3787     4086     +299     
- Partials        564      642      +78     
Flag Coverage Δ
hardhat 98.51% <ø> (ø)
kotlin 64.45% <58.01%> (+0.43%) ⬆️
Files with missing lines Coverage Δ
...in/kotlin/linea/coordinator/config/v2/ApiConfig.kt 100.00% <100.00%> (ø)
.../linea/coordinator/config/v2/toml/ApiConfigToml.kt 100.00% <100.00%> (ø)
...n/linea/coordinator/config/v2/toml/DatabaseToml.kt 100.00% <100.00%> (ø)
...n/linea/coordinator/config/v2/toml/DefaultsToml.kt 100.00% <100.00%> (ø)
...nea/coordinator/config/v2/toml/StateManagerToml.kt 100.00% <100.00%> (ø)
...nator/config/v2/toml/Type2StateProofManagerToml.kt 100.00% <100.00%> (ø)
...sensys/zkevm/coordinator/app/CoordinatorAppMain.kt 0.00% <ø> (ø)
...n/net/consensys/zkevm/ethereum/ContractsManager.kt 61.53% <100.00%> (+0.75%) ⬆️
...n/src/main/kotlin/linea/kotlin/StringExtensions.kt 100.00% <100.00%> (ø)
...faces/src/main/kotlin/linea/ethapi/EthApiClient.kt 50.00% <ø> (ø)
... and 41 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e April 15, 2025 12:58 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from a302a6d to 80c512d Compare May 9, 2025 12:32
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 80c512d to 55171cf Compare May 9, 2025 12:56
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 55171cf to 8fab64a Compare May 13, 2025 07:39
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 8fab64a to 898dfcd Compare May 22, 2025 11:24
@fluentcrafter fluentcrafter changed the title coordinator: adds config v2 sample coordinator: adds config v2 Jun 4, 2025
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 55748b9 to 154d2e0 Compare June 4, 2025 19:51
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 4, 2025 22:37 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter marked this pull request as ready for review June 4, 2025 22:52
@fluentcrafter fluentcrafter requested review from jonesho and Filter94 June 4, 2025 22:52
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 08:09 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 28dd45d to 1b96f32 Compare June 5, 2025 09:22
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 09:40 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter force-pushed the coordinator-config-v2 branch from 859f3c4 to 2b776c6 Compare June 5, 2025 13:51
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 13:51 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 14:30 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 15:04 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter temporarily deployed to docker-build-and-e2e June 5, 2025 21:04 — with GitHub Actions Inactive
@fluentcrafter fluentcrafter requested review from jonesho and Filter94 June 5, 2025 22:55
@fluentcrafter fluentcrafter requested a deployment to docker-build-and-e2e June 6, 2025 02:14 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants