Skip to content

Prover limit update proposal for beta-2.0 #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 24, 2025

Conversation

AlexandreBelling
Copy link
Contributor

@AlexandreBelling AlexandreBelling commented May 2, 2025

(the name of the branch is wrong, it's for beta-2.0 and not Pectra).

The PR proposes an update of the prover limits to be deployed with beta-v2.0. Namely, it reduces the size of the very big modules seeing under utilization and increasing the modules that are strategic to update based on usage stats from last few days (MODEXP, SHF, EXP, ROM). The goal is to allow users relying on MODEXP to be able to send more transactions than what they can do today (4x) and also to allow the conflator to improve the average number of transactions per batch (and therefore increase the prover efficiency).

I checked that the size of the lookup-expanded traces stays roughly the same.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@AlexandreBelling AlexandreBelling added the Prover Tag to use for all work impacting the prover label May 2, 2025
@AlexandreBelling AlexandreBelling self-assigned this May 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.04%. Comparing base (7e306e2) to head (678b7fd).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #936      +/-   ##
============================================
+ Coverage     66.48%   67.04%   +0.55%     
- Complexity     1132     1175      +43     
============================================
  Files           322      338      +16     
  Lines         13000    13318     +318     
  Branches       1357     1363       +6     
============================================
+ Hits           8643     8929     +286     
- Misses         3792     3818      +26     
- Partials        565      571       +6     
Flag Coverage Δ *Carryforward flag
hardhat 98.51% <ø> (ø)
kotlin 64.64% <ø> (+0.66%) ⬆️ Carriedforward from 91532a0

*This pull request uses carry forward flags. Click here to find out more.

see 85 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gusiri
gusiri previously approved these changes May 2, 2025
gusiri
gusiri previously approved these changes May 5, 2025
@AlexandreBelling AlexandreBelling temporarily deployed to docker-build-and-e2e May 23, 2025 18:58 — with GitHub Actions Inactive
@AlexandreBelling AlexandreBelling enabled auto-merge (squash) May 24, 2025 08:49
@AlexandreBelling AlexandreBelling merged commit f113d49 into main May 24, 2025
23 checks passed
@AlexandreBelling AlexandreBelling deleted the prover/limit-changes-for-pectra branch May 24, 2025 09:11
thedarkjester pushed a commit that referenced this pull request Jun 4, 2025
* chores(prover): updates the limits in the local files

* fixup: update SHF for the large prover

* increase ECMUL to 40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants