Prover limit update proposal for beta-2.0 #936
Merged
+73
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
============================================
+ Coverage 66.48% 67.04% +0.55%
- Complexity 1132 1175 +43
============================================
Files 322 338 +16
Lines 13000 13318 +318
Branches 1357 1363 +6
============================================
+ Hits 8643 8929 +286
- Misses 3792 3818 +26
- Partials 565 571 +6
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
gusiri
previously approved these changes
May 2, 2025
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
gusiri
previously approved these changes
May 5, 2025
AlexandreBelling
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
AlexandreBelling
commented
May 9, 2025
…r/limit-changes-for-pectra
AlexandreBelling
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
AlexandreBelling
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
bogdanbear
approved these changes
May 23, 2025
gusiri
approved these changes
May 24, 2025
thedarkjester
pushed a commit
that referenced
this pull request
Jun 4, 2025
* chores(prover): updates the limits in the local files * fixup: update SHF for the large prover * increase ECMUL to 40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the name of the branch is wrong, it's for beta-2.0 and not Pectra).
The PR proposes an update of the prover limits to be deployed with beta-v2.0. Namely, it reduces the size of the very big modules seeing under utilization and increasing the modules that are strategic to update based on usage stats from last few days (MODEXP, SHF, EXP, ROM). The goal is to allow users relying on MODEXP to be able to send more transactions than what they can do today (4x) and also to allow the conflator to improve the average number of transactions per batch (and therefore increase the prover efficiency).
I checked that the size of the lookup-expanded traces stays roughly the same.
Checklist