1970 mxp redesign #1988

lorenzogentile404 · 2025-04-22T13:47:09Z

Redesign of the Mxp module for Cancun where MCOPY is added

The Mxp operation can follow 5 scenarii depending on the opcode. Each scenario executes wcp and euc computations and inherits from the previous scenario as computations are cumulative

1. MSize scenario

no computation

2. Trivial scenario

computes size1IsZero and size2IsZero

3. Mxpx scenario

computes size1IsZero and size2IsZero
computes mxpxExpression

4. State update with word pricing scenario

computes size1IsZero and size2IsZero
computes mxpxExpression
computes state update (wordsNew,cMemNew)
and extraGasCost for word pricing opcodes

5. State update with byte pricing scenario

computes size1IsZero and size2IsZero
computes mxpxExpression
computes state update (wordsNew,cMemNew)
and extraGasCost for byte pricing opcodes

letypequividelespoubelles

I'd suggest to have, for each Mxp instruction, a instMxpCall tht extends an abstract MxpCall where you compute only the needed stuff (see what has been done for OOB).

...tization/src/main/java/net/consensys/linea/zktracer/module/blockdata/BlockdataOperation.java

arithmetization/src/main/java/net/consensys/linea/zktracer/module/euc/EucCall.java

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mxpv3/MxpComputation.java

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mxpv3/MxpOperationV3.java

letypequividelespoubelles · 2025-05-05T10:06:32Z

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mxpv3/MxpUtils.java

+        || opCode.isCall();
+  }
+
+  // This is a copy and past from FrontierGasCalculator.java


don't we already have this somewhere where we compute the exceptions ?

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mxpv3/MxpV3.java

amkCha · 2025-05-07T19:59:35Z

...tion/src/test/java/net/consensys/linea/zktracer/exceptions/MemoryExpansionExceptionTest.java

@@ -52,7 +52,7 @@ public void memoryExpansionExceptionTest(boolean triggerRoob, OpCode opCode) {
        MEMORY_EXPANSION_EXCEPTION,
        bytecodeRunner.getHub().previousTraceSection().commonValues.tracedException());
    assertTrue(bytecodeRunner.getHub().mxp().operations().getLast().getMxpCall().isMxpx());
-    assertEquals(triggerRoob, bytecodeRunner.getHub().mxp().operations().getLast().isRoob());
+    // assertEquals(triggerRoob, bytecodeRunner.getHub().mxp().operations().getLast().isRoob());


@lorenzogentile404 not sure why we comment this part ? Should we keep it while we run London version of Mxp ?

amkCha · 2025-05-07T20:11:02Z

I'd suggest to have, for each Mxp instruction, a instMxpCall tht extends an abstract MxpCall where you compute only the needed stuff (see what has been done for OOB).

Okay so to keep the computation in the Mxp folder and not have it in the Hub, I used the same logic but instead of an abstract MxpCall, I created an abstract class called MxpScenario and I derive the computation in each scenario that extends this class. Let me know if it makes it clear to read else I can always refactor to do it it with an MxpCall abstract class 👌

letypequividelespoubelles

just looked at the logic, not at the implementation

arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/Hub.java

arithmetization/src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/MxpCall.java

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mxp/MxpExoCall.java

...rc/main/java/net/consensys/linea/zktracer/module/mxp/moduleOperation/CancunMxpOperation.java

letypequividelespoubelles · 2025-05-08T07:27:39Z

...rc/main/java/net/consensys/linea/zktracer/module/mxp/moduleOperation/CancunMxpOperation.java

+          .pComputationArg2Hi(scenario.exoCalls.get(i).arg2Hi())
+          .pComputationArg2Lo(scenario.exoCalls.get(i).arg2Lo())
+          .pComputationResA(scenario.exoCalls.get(i).resultA().toLong())
+          .pComputationResB(scenario.exoCalls.get(i).resultB().toLong())


You might have sign issues :) we have conversion Bytes to unsignedLong somewhere

...on/src/main/java/net/consensys/linea/zktracer/module/mxp/moduleScenario/MxpxMxpScenario.java

… opcode

…on and Cancun

lorenzogentile404 linked an issue Apr 22, 2025 that may be closed by this pull request

MXP redesign #1970

Open

amkCha force-pushed the 1970-mxp-redesign branch from 9e73108 to b14cc55 Compare April 30, 2025 16:03

letypequividelespoubelles reviewed May 5, 2025

View reviewed changes

amkCha force-pushed the 1970-mxp-redesign branch from 257bec4 to a517c87 Compare May 7, 2025 19:56

amkCha reviewed May 7, 2025

View reviewed changes

letypequividelespoubelles reviewed May 8, 2025

View reviewed changes

lorenzogentile404 and others added 23 commits May 12, 2025 15:04

updated constraints

5e05536

updated constraints

b17bd3e

added structure for size and offset setting, tracing, maxct and MCOPY…

47e7556

… opcode

splitted tracing method based on perspective

b6e1af0

cleaned mxp and partially updated it

e905c5a

reverted opcodes update

103b2a6

feat: trace decoder single and double offset

281272d

feat: handleTrivial, handleMxpx, handleUpdt

8ea6d6a

feat: MxpCall refacto, Mxp v3 computations, MxpScenario

554c1bf

fix: max offset computation

34fae39

feat: update constraints, enable trace previous mxp

7d259da

feat: merge mxp and mxp redesign with london/shanghai forks

e0eaa03

feat: rename to Cancun

027c87e

feat: split scenario by classes

a67eab3

feat: comments on method

8c47e75

feat: computation split and serious commenting

0163ebc

feat: state update computation

45b1025

feat: adapt trace method for LondonMxp and CancunMxp

b12287d

fix: remove falsy comment

8effdf4

fix: abstract method

eb3f350

fix: make Mxp module class abstract

4df7e01

fix: make variables final

4e886ea

fix: switch resA to boolean

1a34013

amkCha added 2 commits May 12, 2025 15:05

feat: mxpCall abstract part 1

f4e7a9d

fix: getMxpScenario

9d67898

amkCha force-pushed the 1970-mxp-redesign branch from 7f7fe8a to 9d67898 Compare May 12, 2025 13:44

amkCha added 7 commits May 12, 2025 16:30

feat: compute in constructor

a501610

feat: cancun opcodes yaml

7fa895a

fix: static mxpxthreshold

e1994e1

update constraints

433b15a

fix: operations method and call public for Mxp class

ba001bd

fix: getMxpScenario logic and rename mxpCall in MxpOperation for Lond…

5f120a3

…on and Cancun

feat: fill cancun opcodes yaml file

c577ffc

amkCha force-pushed the 1970-mxp-redesign branch from 62eec10 to c577ffc Compare May 14, 2025 13:00

fix: super call

3a74cf6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

1970 mxp redesign #1988

1970 mxp redesign #1988

Uh oh!

lorenzogentile404 commented Apr 22, 2025 •

edited by amkCha

Loading

Uh oh!

letypequividelespoubelles left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

letypequividelespoubelles May 5, 2025

Uh oh!

Uh oh!

amkCha May 7, 2025

Uh oh!

amkCha commented May 7, 2025

Uh oh!

letypequividelespoubelles left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

letypequividelespoubelles May 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

1970 mxp redesign #1988

Are you sure you want to change the base?

1970 mxp redesign #1988

Uh oh!

Conversation

lorenzogentile404 commented Apr 22, 2025 • edited by amkCha Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

letypequividelespoubelles left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

letypequividelespoubelles May 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amkCha May 7, 2025

Choose a reason for hiding this comment

Uh oh!

amkCha commented May 7, 2025

Uh oh!

letypequividelespoubelles left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

letypequividelespoubelles May 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lorenzogentile404 commented Apr 22, 2025 •

edited by amkCha

Loading