Skip to content

Conversation

@zilm13
Copy link
Contributor

@zilm13 zilm13 commented Oct 29, 2025

PR Description

I don't like tests by logs too, but it's the best thing we could have now to check all wiring is correctly set and remains correct after restart. The only thing we could check not by the logs is cgc in Metadata and I check it too.

UPDATE: It's not possible to test after restart part because persistence requires other CircleCI docker tier, see documentation. This part of tests was dropped.

UPDATE2: It was suggested to keep restart part code in tests, anyone could still run it locally + maybe GHA will solve Docker issue or any other update in used CI. The way I did it maybe not the best, so any suggestions are appreciated.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Adds acceptance tests validating custody/sampling group counts (incl. super node) and metadata, plus DSL utilities for parallel waits, metadata fetch, persistence, and custody subnet config; also tweaks a debug log.

  • Acceptance Tests:
    • Add DasCustodyCountAcceptanceTest verifying custody group count and sampling group count across validator, full, and super node setups, including checks after restart (gated by SKIP_RESTART) and cgc in Metadata.
  • Test DSL Enhancements:
    • Node: add waitForAllInAnyOrder(...) to run multiple wait conditions concurrently.
    • TekuBeaconNode: add getMetadataMessage(SpecMilestone) to parse node identity metadata.
    • TekuNode: add withPersistentStore(Path) to mount a writable data directory for restart tests.
    • TekuNodeConfigBuilder: add withSubscribeAllCustodySubnetsEnabled() to set p2p-subscribe-all-custody-subnets-enabled.
  • Networking:
    • Adjust debug log in DataColumnSidecarSubnetBackboneSubscriber (“Sampling group count...” message formatting).

Written by Cursor Bugbot for commit 2ccd229. This will update automatically on new commits. Configure here.

@zilm13 zilm13 changed the title Acceptance Test: Check custody count number is set among all components Acceptance Test: Check custody count number is set in all components Oct 29, 2025
@zilm13 zilm13 marked this pull request as ready for review October 30, 2025 20:12
cursor[bot]

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant