Acceptance Test: Check custody count number is set in all components #10074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
I don't like tests by logs too, but it's the best thing we could have now to check all wiring is correctly set and remains correct after restart. The only thing we could check not by the logs is
cgcinMetadataand I check it too.UPDATE: It's not possible to test after restart part because persistence requires other CircleCI docker tier, see documentation. This part of tests was dropped.
UPDATE2: It was suggested to keep restart part code in tests, anyone could still run it locally + maybe GHA will solve Docker issue or any other update in used CI. The way I did it maybe not the best, so any suggestions are appreciated.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Adds acceptance tests validating custody/sampling group counts (incl. super node) and metadata, plus DSL utilities for parallel waits, metadata fetch, persistence, and custody subnet config; also tweaks a debug log.
DasCustodyCountAcceptanceTestverifying custody group count and sampling group count across validator, full, and super node setups, including checks after restart (gated bySKIP_RESTART) andcgcinMetadata.Node: addwaitForAllInAnyOrder(...)to run multiple wait conditions concurrently.TekuBeaconNode: addgetMetadataMessage(SpecMilestone)to parse node identity metadata.TekuNode: addwithPersistentStore(Path)to mount a writable data directory for restart tests.TekuNodeConfigBuilder: addwithSubscribeAllCustodySubnetsEnabled()to setp2p-subscribe-all-custody-subnets-enabled.DataColumnSidecarSubnetBackboneSubscriber(“Sampling group count...” message formatting).Written by Cursor Bugbot for commit 2ccd229. This will update automatically on new commits. Configure here.