10175 execution payload bid gloas gossip #10198

mehdi-aouadi · 2025-12-02T18:32:32Z

PR Description

Add Gloas execution_payload_bid gossip rules

Fixed Issue(s)

#10175

Documentation

I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

I thought about adding a changelog entry, and added one if I deemed necessary.

Note

Adds Gloas execution_payload_bid gossip validation with helper utilities and integrates it into the bid manager and node, plus constants, test utilities, and updated tests/fixtures.

Gloas Bid Gossip Validation:
- Add ExecutionPayloadBidGossipValidator with checks (slot window, parent hash/root known, builder validity/credentials/balance, non-zero execution_payment reject, signature, highest-bid tracking) using LRU caches (SEEN_EXECUTION_PAYLOAD_BID_SET_SIZE, HIGHEST_BID_SET_SIZE).
- Hook validator into DefaultExecutionPayloadBidManager.validateAndAddBid.
Node Integration:
- Instantiate and wire bid validator in BeaconChainController.initExecutionPayloadBidManager().
Helpers & Config:
- Extend GossipValidationHelper (current/next slot, builder index/credentials/balance, block-hash known, signature helpers).
- Expose MiscHelpersGloas.hasBuilderWithdrawalCredential.
- Add constants: SEEN_EXECUTION_PAYLOAD_BID_SET_SIZE, HIGHEST_BID_SET_SIZE in Constants.
Test Utilities:
- Enhance DataStructureUtil to generate ExecutionPayloadBid/SignedExecutionPayloadBid with explicit fields/variants.
Tests:
- New tests for bid gossip validation and helper behaviors; update bid manager test and signer expected signature.
Fixtures:
- Update Gloas block JSONs with new signed_execution_payload_bid values to match changes.

^{Written by Cursor Bugbot for commit 100dec8. This will update automatically on new commits. Configure here.}

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

...ition/src/main/java/tech/pegasys/teku/statetransition/validation/GossipValidationHelper.java

...main/java/tech/pegasys/teku/statetransition/execution/DefaultExecutionPayloadBidManager.java

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

...main/java/tech/pegasys/teku/statetransition/execution/DefaultExecutionPayloadBidManager.java

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

...ition/src/main/java/tech/pegasys/teku/statetransition/validation/GossipValidationHelper.java

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

zilm13 · 2025-12-23T16:32:25Z

...ition/src/main/java/tech/pegasys/teku/statetransition/validation/GossipValidationHelper.java

+  public boolean isValidBuilderIndex(
+      final UInt64 builderIndex, final BeaconState state, final UInt64 slot) {
+    if (builderIndex.isGreaterThanOrEqualTo(state.getValidators().size())
+        || builderIndex.longValue() < 0) {


intValue, as we use it as int right after that?

zilm13 · 2025-12-23T16:35:17Z

...ition/src/main/java/tech/pegasys/teku/statetransition/validation/GossipValidationHelper.java

+    final int index = builderIndex.intValue();
+    final Validator builder = state.getValidators().get(index);
+    final boolean isActiveBuilder =
+        spec.getActiveValidatorIndices(state, spec.computeEpochAtSlot(slot)).contains(index);


Look heavy for this, we already have Validator structure for this specific state. Can we use predicates.isActiveValidator for the check?

zilm13 · 2025-12-23T20:35:50Z

...ition/src/main/java/tech/pegasys/teku/statetransition/validation/GossipValidationHelper.java

+  }
+
+  public boolean isBlockHashKnown(final Bytes32 blockHash, final Bytes32 blockRoot) {
+    // TODO-GLOAS check this logic. We might need to check the block hash existence in the store


I think we have the same in Store, we use both ForkChoiceStrategy and Store for such checks in validation helpers like it's interchangeable.
Spec is literally saying for this check: bid.parent_block_hash is the block hash of a known execution payload in fork choice., so you could remove TODO

zilm13 · 2025-12-23T20:42:57Z

ethereum/spec/src/main/java/tech/pegasys/teku/spec/config/Constants.java

  public static final int VALID_PAYLOAD_ATTESTATION_SET_SIZE = 512 * 2;
  // Target holding two slots worth of aggregators (16 aggregators, 64 committees and 2 slots)
  public static final int VALID_AGGREGATE_SET_SIZE = 16 * 64 * 2;
  // Target 2 different attestation data (aggregators normally agree) for two slots


Comment is from VALID_ATTESTATION_DATA_SET_SIZE probably, you've inserted in the middle

zilm13 · 2025-12-23T20:50:23Z

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

+  final SigningRootUtil signingRootUtil;
+
+  private final Set<BuilderIndexAndSlot> seenExecutionPayloadBids =
+      LimitedSet.createSynchronized(SEEN_EXECUTION_PAYLOAD_BID_SET_SIZE);


I think it's better to base this one number of slots rather than some random big number always occupying memory. Maybe Map<Slot, Set<UInt64>> for 10 slots could be a better for memory? You will also need synchronized internal sets.
What do you think?

zilm13 · 2025-12-23T21:06:45Z

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

+    final Optional<UInt64> maybeParentBlockSlot =
+        gossipValidationHelper.getSlotForBlockRoot(bid.getParentBlockRoot());
+    if (maybeParentBlockSlot.isEmpty()) {
+      LOG.trace("Bid's parent block does not exist. It will be saved for future processing");


we don't expect this with previous check passed, but anyway, let's add blockRoot to the log string

zilm13 · 2025-12-23T21:08:08Z

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

+                LOG.trace(
+                    "State for block root {} and slot {} is unavailable.",
+                    bid.getParentBlockRoot(),
+                    bid.getSlot());


parentBlockSlot?

zilm13 · 2025-12-23T21:12:34Z

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

+               * [REJECT] bid.builder_index is a valid, active, and non-slashed builder index.
+               */
+
+              final UInt64 buildrIndex = bid.getBuilderIndex();


builderIndex

zilm13 · 2025-12-23T21:22:23Z

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java

+                LOG.trace("Invalid payload execution bid signature");
+                return reject("Invalid payload execution bid signature");
+              }
+              highestBids.merge(bidValueKey, bid.getValue(), UInt64::max);


why? I don't understand. If it's really needed, we need a comment here

zilm13 · 2025-12-23T21:28:48Z

...ava/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidatorTest.java

+    assertThatSafeFuture(bidValidator.validate(signedBid)).isCompletedWithValue(ACCEPT);
+
+    // a same value bid from a different builder with the same parent block hash and slot
+    final SignedExecutionPayloadBid lowerValueBid =


sameValueBid?

mehdi-aouadi self-assigned this Dec 2, 2025

mehdi-aouadi added the Epic Gloas label Dec 2, 2025

cursor bot reviewed Dec 2, 2025

View reviewed changes

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java Outdated Show resolved Hide resolved

...ition/src/main/java/tech/pegasys/teku/statetransition/validation/GossipValidationHelper.java Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Dec 2, 2025

View reviewed changes

...main/java/tech/pegasys/teku/statetransition/execution/DefaultExecutionPayloadBidManager.java Fixed Show fixed Hide fixed

cursor bot reviewed Dec 2, 2025

View reviewed changes

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java Outdated Show resolved Hide resolved

mehdi-aouadi force-pushed the 10175-execution-payload-bid-gloas-gossip branch from 44d6922 to c590df1 Compare December 3, 2025 14:31

cursor bot reviewed Dec 3, 2025

View reviewed changes

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Dec 3, 2025

View reviewed changes

...main/java/tech/pegasys/teku/statetransition/execution/DefaultExecutionPayloadBidManager.java Show resolved Hide resolved

cursor bot reviewed Dec 3, 2025

View reviewed changes

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java Show resolved Hide resolved

mehdi-aouadi added 9 commits December 4, 2025 11:03

fix slot rule

ea473cc

nit

64ad76d

renaming helper methods

fc72944

remove time provider from gossip helper

c72af65

add gloas execution payload bid gossip rules

6005d32

fiw tests

65a394d

fixes

54f3827

nit

05cd664

update current or next slot rule

f006907

mehdi-aouadi force-pushed the 10175-execution-payload-bid-gloas-gossip branch from 2d10e2d to f006907 Compare December 4, 2025 10:10

cursor bot reviewed Dec 4, 2025

View reviewed changes

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java Outdated Show resolved Hide resolved

handle highest bids race condition

e98822b

cursor bot reviewed Dec 4, 2025

View reviewed changes

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java Show resolved Hide resolved

mehdi-aouadi marked this pull request as draft December 4, 2025 17:31

fix highest bid cache

e9375c2

mehdi-aouadi marked this pull request as ready for review December 4, 2025 17:48

merge branch master

05eb1ae

cursor bot reviewed Dec 9, 2025

View reviewed changes

...ition/src/main/java/tech/pegasys/teku/statetransition/validation/GossipValidationHelper.java Show resolved Hide resolved

hadnle overflow

2555225

cursor bot reviewed Dec 9, 2025

View reviewed changes

...in/java/tech/pegasys/teku/statetransition/validation/ExecutionPayloadBidGossipValidator.java Outdated Show resolved Hide resolved

fix highest bid filtering

100dec8

zilm13 reviewed Dec 23, 2025

View reviewed changes

10175 execution payload bid gloas gossip #10198

Are you sure you want to change the base?

10175 execution payload bid gloas gossip #10198

Uh oh!

Conversation

mehdi-aouadi commented Dec 2, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Description

Fixed Issue(s)

Documentation

Changelog

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mehdi-aouadi commented Dec 2, 2025 •

edited by cursor bot

Loading