Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just an idea, to be validated in real world, and it could explain why, before #10219, we were actually duplicating download requests instead of just rebuilding the tracker which then completes immediately.
if that's the case, the underlining design problem\bug is that we don't write Columns via
CombinedStorageChannelSplitter.CombinedStorageChannelSplitterguarantees that reads are happening only after writes.this approach is beneficial because it does not wait the writes, and can be very useful for quickly serving byRoot RPCs on the block head.
We should probably fix
CombinedStorageChannelSplitteranyway too.Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Caches in-flight DataColumnSidecar writes to satisfy immediate reads and reduce redundant DB access, with tests verifying behavior.
inflightColumnsinColumnIdCachingDasDb.addSidecar, store sidecar under itsDataColumnSlotAndIdentifierand remove after write completes.getSidecar, return from in-flight cache before delegating to underlying DB.latestAddedand invalidates slot read cache on write.shouldCacheInflightSidecarsto assert immediate reads hit the in-flight cache and minimize underlying DB reads.Written by Cursor Bugbot for commit 06c7d47. This will update automatically on new commits. Configure here.