Fix missing context menu for certain controls widgets #3408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... that use 'options' in their Confirmation Dialog meaning that this property value cannot be converted to a Boolean and so an exception is being thrown. See ISSUE 3407.
Previous change is only applicable to control widgets with the confirm dialog. Other widgets do not have these properties and so first we should check if they are present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any widget that uses an 'option' for their Confirmation Dialog (e.g. None, On both, on set, etc) is throwing an exception when you right click to display the context menu. This is because this property value cannot be converted to a Boolean.
See ISSUE 3407 for full details.
I have fixed this by also obtaining the
propConfirmDialogOptionsproperty and checking whether it is of typeConfirmDialog. If it is then I use logic to convert the enum to a boolean. If it is not then we are in the original case where the Confirmation Dialog is just true/false so we can obtain the value from that. A boolean cannot be converted to aConfirmDialogenum and aConfirmDialogenum cannot be converted to a boolean so I think the only way to check this is to grab both property values.