Wrap Elog plain text inside <p> tag #3414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the previous PR #3413 affects the behavior of Olog, and the approach is not appropriate. So this PR takes a different approach.
For Elog, there are three kind of encodings as follows,
plain
ELCode
HTML
For
HTMLencoding, the newline is controlled by the<p>tag and whitespace by , so there is no problem when displayed on Olog UI.For
plainencoding, this PR wraps the Elog text inside<p style="white-space: pre-wrap;"></p>tag in order to preserve whitespaces.