show in red incorrect properties in settings.ini

[lcaouen]

Shows in the About dialog box the incorrect settings from settings.ini.
It compares the settings from the settings.ini to the settings from the preferences.properties
The incorrect ones are displayed in red

This is related to this issue :
#3605

• Testing:

  • tested manually by @lcaouen @minijackson

• Documentation:

  • A message is displayed at the top of the view in the about dialog saying the settings in red are incorrects

[georgweiss]

Unfortunately not able to get the intended behavior.
Starting without any path to a settings file I get:

Starting with a custom settings file (correct settings) specified through -settings /path/to/settings/file.ini I get:

[lcaouen]

Don't know what I've done in my PR but some code is missing. I'm gonna check tomorrow

[lcaouen]

Even if there is some code missing, the code in this PR should work.
To find the correct settings, I use the classpath variable to open all the jars and then load all the settings.
Then I compare these settings to the ones in settings.ini.

I think your classpath is empty, because you use another method to load the jars.
We don't use the .sh or .bat provided during the build which apparently use a "main" jar to load all the other jars.
I 'm gonna check what I can do to take into account this other method, and also add the code I lost which was using another font and escaping the potential html in the settings

[lcaouen]

Here is the result I get when it works ;-)

[georgweiss]

Are you launching Phoebus with a -classpath command line argument?

[lcaouen]

Are you launching Phoebus with a -classpath command line argument?

Yes we put the lib path in the -classpath whereas the .sh or .bat to launch Phoebus with the official version uses the product-*.jar and the classpath in the manifest

[lcaouen]

I have updated the source code.
If there is only one jar in the classpath, it opens it to get the paths of the other jars.
I have also added the "misssing code"

• a monospace font
• escape the html tags in the properties
• a message at the top saying properties in red are incorrects