add support for CoolProp_jll v8.0.0 - #49
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
CoolProp_jll Version Bump
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Local test (and presumably the now running CI) fails with: It's not clear to me how to fix this. |
|
curious how it works for fugacity but not for fugacity_coefficient. the error comes from here: |
|
This should be fixed in CoolProp/CoolProp#3262, so i think we need to wait up until the next library release. |
|
Is there a way to hook the julia unit tests into the CoolProp ones? |
|
it is not too hard (i did it in a different way before in Clapeyron), but it would require some changes in the package: This line is the main interaction:
One could use import CoolProp_jll #in this way, we do not import libcoolprop into the module. until asked
#Preferences was introduced in julia 1.6, this package supports even older versions of julia (last LTS version is 1.10)
@static if VERSION >= v"1.6"
using Preferences
end
@static if VERSION >= v"1.6"
const libcoolprop = @load_preference("coolprop_library", CoolProp_jll.libcoolprop)
else
const libcoolprop = CoolProp_jll.libcoolprop
endThe only thing missing is the loading, probably a github worker could be written here that checks the coolprop master once a day and runs the tests with that library instead of the one provided by the package manager. |
needs JuliaPackaging/Yggdrasil#14076 first.
Summary by CodeRabbit